move sample realtime events for put/patch/delete to api layer #294
Conversation
shriramshankar
changed the base branch from
perms-for-upsert-enpoints
to
master
shriramshankar
changed the base branch from
master
to
perms-for-upsert-enpoints
| const aspName = nameParts[1]; | ||
| const subOpts = { | ||
| where: { | ||
| absolutePath: subName, |
| }; | ||
| const aspOpts = { | ||
| where: { | ||
| name: aspName, |
There was a problem hiding this comment.
aspectName and subjectName are always from the "sample.name" field from the db and the "sample.name" field is formed from its subject and its aspect in the db. So the case always matches when we do the find here.
| .catch(done); | ||
| }); | ||
|
|
||
| it('when tried to publish sample without aspect,'+ |
There was a problem hiding this comment.
any other tests we can add here to make sure that we aren't breaking any of the existing realtime event publishing?
There was a problem hiding this comment.
The sample object the is finally passed to the real-time emitter should have the following fields/objects to not to break anything
- absolutePath - as a field copied over from subject absolutePath
- subject object always attached - having tags field
- aspect object always attached having tags field
I have added tests to check for these.
api/v1/helpers/verbs/doPut.js
Outdated
| // publish the update event to the redis channel | ||
| if (props.publishEvents) { | ||
| publisher.publishSample(o, props.associatedModels.subject, | ||
|
|
There was a problem hiding this comment.
is there a reason we are adding an empty line here?
| * | ||
| * @param {Sample} inst - The newly-created instance | ||
| */ | ||
| afterCreate(inst /* , opts */) { |
There was a problem hiding this comment.
can we test for whether a sample is published on realtime create and delete?
There was a problem hiding this comment.
There is another story for this.
iamigo
changed the title
|
@annyhe Can you merge this PR? |
No description provided.