chore(ci): fix numerical comparison#2316
Merged
Merged
Conversation
iowillhoit
approved these changes
Jul 29, 2025
Contributor
iowillhoit
left a comment
There was a problem hiding this comment.
NOTE: The deprecation failure is expected salesforcecli/plugin-agent#175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the string comparison done in the nightly PR workflow that was blocking new nightly releases after the
2.100.0RC, see copilot explanation below ⏬Acceptance Criteria
How do you know this change is successful? What is the scope of this change? What tests test the criteria (or why no tests)?
The Acceptance Criteria can be copied from the work item if they exist there but it is useful to have on the PR when reviewing the code.
Testing Notes
Successfully created a 2.100.1 nightly from this branch:
https://github.com/salesforcecli/cli/actions/runs/16606422530/job/46979279048
docs:
https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#operators
🪄 fixed by copilot agent using sonnet 4, prompt:
⬇️
What issues does this PR fix or reference?
[skip-validate-pr]