W-18506859: exclude node_modules dir from yaml files inspection#143
Merged
W-18506859: exclude node_modules dir from yaml files inspection#143
Conversation
shetzel
reviewed
May 16, 2025
| 'subdir/file4.yaml', | ||
| 'node_modules/file5.yml', | ||
| 'excluded/file6.yaml', | ||
| ] as const; |
Contributor
There was a problem hiding this comment.
This works on posix as intended but it only works on Windows because of how the test expectations are written (without join or path.sep). On windows, I bet all the files are written directly within testDir with file names of excluded/file6.yaml, etc.
Contributor
Author
There was a problem hiding this comment.
Got it. Thanks for fixing it.
shetzel
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Excludes YAML files from
node_modulesdirectory as suggestions for file specs.What issues does this PR fix or reference?
@W-18506859@