fix: handle null template validation messages#236
Merged
Conversation
smithgp
commented
Mar 1, 2023
| label: task.label, | ||
| readinessStatus: task.readinessStatus, | ||
| message: task.message | ||
| label: task.label || '', |
Collaborator
Author
There was a problem hiding this comment.
sfdx's ux.table doesn't like nulls, it throw a js error. And, I'm getting nulls on at least message in my current build
Collaborator
There was a problem hiding this comment.
do you need the same change in lint.ts?
Collaborator
Author
There was a problem hiding this comment.
I'm seeing any nulls actually coming out in the lint responses currently, but, yeah, probably should do it there, too. I'll have it up in a sec.
Collaborator
Author
There was a problem hiding this comment.
Ok, updated lint.ts too
| tmp/ | ||
|
|
||
| # tsc will sometimes make these | ||
| tsconfig.tsbuildinfo |
Collaborator
Author
There was a problem hiding this comment.
yarn build spit this file out, could be from newer versions of typescript, but the internet says we can ignore it.
reidaelliott
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle null template validation messages
What issues does this PR fix or reference?
@W-12573263@