Skip to content

fix: handle null template validation messages #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smithgp merged 2 commits into from
Mar 2, 2023
Merged

fix: handle null template validation messages #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74fdc6a
fix: handle null template validation messages
smithgp Mar 1, 2023
f3b82c1
fix: handle nulls on lint responses
smithgp Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# -- CLEAN
tmp/

# tsc will sometimes make these
tsconfig.tsbuildinfo
Copy link
Copy Markdown
Collaborator Author

@smithgp smithgp Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn build spit this file out, could be from newer versions of typescript, but the internet says we can ignore it.


# use yarn by default, so ignore npm
package-lock.json

Expand Down
6 changes: 3 additions & 3 deletions src/commands/analytics/template/lint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ export default class Lint extends SfdxCommand {
this.ux.table(
tasks.map(task => {
return {
label: task.label,
readinessStatus: task.readinessStatus,
message: task.message
label: task.label || '',
readinessStatus: task.readinessStatus || '',
message: task.message || ''
};
}),
{
Expand Down
6 changes: 3 additions & 3 deletions src/commands/analytics/template/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ export default class Validate extends SfdxCommand {
this.ux.table(
tasks.map(task => {
return {
label: task.label,
readinessStatus: task.readinessStatus,
message: task.message
label: task.label || '',
Copy link
Copy Markdown
Collaborator Author

@smithgp smithgp Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sfdx's ux.table doesn't like nulls, it throw a js error. And, I'm getting nulls on at least message in my current build

Copy link
Copy Markdown
Collaborator

@reidaelliott reidaelliott Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need the same change in lint.ts?

Copy link
Copy Markdown
Collaborator Author

@smithgp smithgp Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing any nulls actually coming out in the lint responses currently, but, yeah, probably should do it there, too. I'll have it up in a sec.

Copy link
Copy Markdown
Collaborator Author

@smithgp smithgp Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, updated lint.ts too

readinessStatus: task.readinessStatus || '',
message: task.message || ''
};
}),
{
Expand Down
6 changes: 3 additions & 3 deletions src/lib/analytics/template/lint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ export type LintType = Record<string, unknown> & {
};

export type Tasks = {
label?: string;
message?: string;
readinessStatus?: string;
label?: string | null;
message?: string | null;
readinessStatus?: string | null;
};

export default class TemplateLint {
Expand Down
6 changes: 3 additions & 3 deletions src/lib/analytics/template/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ export type ValidateType = Record<string, unknown> & {
};

export type Tasks = {
label?: string;
message?: string;
readinessStatus?: string;
label?: string | null;
message?: string | null;
readinessStatus?: string | null;
};

export default class TemplateValidate {
Expand Down