fix: add recipe ids W-11157722#118
Conversation
|
|
||
| EXAMPLE | ||
| $ sfdx analytics:template:create -f folderid | ||
| $ sfdx analytics:template:create -f folderid -r "05vxx0000004CAeAAM, 05vxx0000004C92AAE" |
There was a problem hiding this comment.
I think these print out when you run help, I think typically i put something like versus an actual id
There was a problem hiding this comment.
I believe this portion of the README is actually auto-generated from the actual command source itself, so you don't need to add in the -r flag directly. Also, it get an example added here, you should instead update the examples class variable in the command .ts (e.g. create.ts). You can probably revert this file in the PR since it I think it's going to get overwritten on publish anyways.
There was a problem hiding this comment.
yeah i missed that its in the readme file, this should go in create.ts, and just use "recipeid" versus an actual id
| "assetVersionFlagLongDescription": "Version number for upgrading the template." | ||
| "assetVersionFlagLongDescription": "Version number for upgrading the template.", | ||
| "recipeidsFlagDescription": "comma-separated list of recipe IDs", | ||
| "recipeidsFlagLongDescription": "comma-separated list of recipe IDs to be includes with the template. " |
There was a problem hiding this comment.
Nit:
| "recipeidsFlagLongDescription": "comma-separated list of recipe IDs to be includes with the template. " | |
| "recipeidsFlagLongDescription": "comma-separated list of recipe IDs to be included with the template. " |
|
|
||
| EXAMPLE | ||
| $ sfdx analytics:template:create -f folderid | ||
| $ sfdx analytics:template:create -f folderid -r "05vxx0000004CAeAAM, 05vxx0000004C92AAE" |
There was a problem hiding this comment.
I believe this portion of the README is actually auto-generated from the actual command source itself, so you don't need to add in the -r flag directly. Also, it get an example added here, you should instead update the examples class variable in the command .ts (e.g. create.ts). You can probably revert this file in the PR since it I think it's going to get overwritten on publish anyways.
|
|
||
| EXAMPLE | ||
| $ sfdx analytics:template:create -f folderid | ||
| $ sfdx analytics:template:create -f folderid -r "05vxx0000004CAeAAM, 05vxx0000004C92AAE" |
There was a problem hiding this comment.
yeah i missed that its in the readme file, this should go in create.ts, and just use "recipeid" versus an actual id
3 participants
What does this PR do?
Adds optional recipeids to the template:create and update command
What issues does this PR fix or reference?
@W-11157722@