Skip to content

Conversation

@mshanemc
Copy link
Contributor

What does this PR do?

  • use the arrayWithDeprecations to let comma-separaterd stuff work like new commands and provide warnings when people use commas
  • reduce manual validation via oclif exclusive flags

What issues does this PR fix or reference?

forcedotcom/cli#2165
@W-13505755@

@mshanemc mshanemc requested a review from a team as a code owner May 31, 2023 20:51
@mshanemc mshanemc requested a review from WillieRuemmele May 31, 2023 20:52
@WillieRuemmele
Copy link
Contributor

QA Notes


before:

 ➜  ../../oss/plugin-apex/bin/dev apex:run:test -t GeocodingServiceTest,FileUtilitiesTest -w 10
=== Test Summary

after:
✅ :

 ➜  ../../oss/plugin-apex/bin/dev apex:run:test -t GeocodingServiceTest,FileUtilitiesTest -w 10
Warning: The input format for array arguments has changed. Use this format: --array-flag value1 --array-flag value2 --array-flag value3
Warning: The input format for array arguments has changed. Use this format: --array-flag value1 --array-flag value2 --array-flag value3
=== Test Summary

✅ :

 ➜  ../../oss/plugin-apex/bin/dev apex:run:test -t GeocodingServiceTest -t FileUtilitiesTest -w 10
=== Test Summary

✅ :

 ➜  ../../oss/plugin-apex/bin/dev apex:run:test -n GeocodingServiceTest -n FileUtilitiesTest -w 10
=== Test Summary

✅ :

 ➜  ../../oss/plugin-apex/bin/dev apex:run:test -n GeocodingServiceTest,FileUtilitiesTest -w 10  
Warning: The input format for array arguments has changed. Use this format: --array-flag value1 --array-flag value2 --array-flag value3
Warning: The input format for array arguments has changed. Use this format: --array-flag value1 --array-flag value2 --array-flag value3
=== Test Summary

✅ :

 ➜  ../../oss/plugin-apex/bin/dev apex:run:test -t GeocodingServiceTest -n FileUtilitiesTest -w 10
Error (1): The following errors occurred:
  --class-names=FileUtilitiesTest cannot also be provided when using --tests
  --tests=GeocodingServiceTest cannot also be provided when using --class-names

✅ :

 ➜  ../../oss/plugin-apex/bin/dev apex:run:test -n GeocodingServiceTest -s FileUtilitiesTest -w 10
Error (1): The following errors occurred:
  --class-names=GeocodingServiceTest cannot also be provided when using --suite-names
  --suite-names=FileUtilitiesTest cannot also be provided when using --class-names

@WillieRuemmele WillieRuemmele merged commit b91a8f5 into main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants