Skip to content

fix: call testService method to store testRunId #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WillieRuemmele merged 2 commits into from
Jul 24, 2023
Merged

fix: call testService method to store testRunId #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f606104
fix: call testService method to store testRunId
mshanemc Jul 21, 2023
00881d8
test: nut for test-run-id file
mshanemc Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/commands/apex/run/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,13 @@ export default class Test extends SfCommand<RunCommandResult> {
// Log the proper 'apex get test' command for the user to run later
this.log(messages.getMessage('runTestReportCommand', [this.config.bin, result.testRunId, conn.getUsername()]));
this.info(messages.getMessage('runTestSyncInstructions'));

if (flags['output-dir']) {
// testService writes a file with just the test run id in it to test-run-id.txt
// github.com/forcedotcom/salesforcedx-apex/blob/c986abfabee3edf12f396f1d2e43720988fa3911/src/tests/testService.ts#L245-L246
await testService.writeResultFiles(result, { dirPath: flags['output-dir'] }, flags['code-coverage']);
}

return result;
}
}
Expand Down
14 changes: 14 additions & 0 deletions test/commands/apex/run/test.nut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,20 @@ describe('apex run test', () => {
execCmd(`apex:get:test -i ${result?.testRunId}`, { ensureExitCode: 0 });
});

it('will save test-run-id file for async', async () => {
const resultDir = 'asyncResults';
const result = execCmd<TestRunIdResult>(`apex:run:test --json --output-dir ${resultDir}`, { ensureExitCode: 0 })
.jsonOutput?.result;
expect(result?.testRunId).to.be.a('string');
expect(result?.testRunId.startsWith('707')).to.be.true;
const outputDir = path.join(session.project.dir, resultDir);
const testRunIdFile = path.join(outputDir, 'test-run-id.txt');
expect(fs.existsSync(testRunIdFile)).to.be.true;
expect(await fs.promises.readFile(testRunIdFile, 'utf-8')).equal(result?.testRunId);
// get the test results to make sure it's not 'ALREADY IN PROGRESS' or 'QUEUED' for the next test
execCmd(`apex:get:test -i ${result?.testRunId}`, { ensureExitCode: 0 });
});

it('will run default tests and default async', async () => {
const result = execCmd('apex:run:test', { ensureExitCode: 0 }).shellOutput.stdout;
expect(result).to.include('apex get test -i 707');
Expand Down