feat: Add Github Actions and Update Dependency Versions #2

klewis-sfdc · 2022-11-11T23:42:55Z

What does this PR do?

Adds Github Actions workflows to this repo, which were done using CircleCI when this project lived at forcedotcom/salesforcedx-apex.

What issues does this PR fix or reference?

Implements CI using Github Actions. Directory initially copied from salesforcecli/plugin-template.

This PR also updates the versions of @salesforce/core and @salesforce/apex-node used by the plugin.

@W-11309523@

.github/CODEOWNERS

randi274 · 2022-11-15T16:22:47Z

@klewis-sfdc I actually don't think we want to manage the plugin github actions ourselves. I would recommend a PR adding this instead to the Leif repo, so this can be added to the list of centrally managed repos that the CLI team manages: https://github.com/salesforcecli/leif/blob/main/weekly-leif.yml

klewis-sfdc · 2022-11-16T14:43:36Z

Thanks for reviewing the PR @randi274. It looks to me like leif used to sync github actions, but no longer does: https://github.com/salesforcecli/leif/pull/53/files

This reverts commit 1d47d56.

This reverts commit 3f99013.

this repo disnt have any and the action fails

This reverts commit 9b62510.

This reverts commit e060806.

klewis-sfdc · 2022-12-08T13:38:28Z

test/commands/force/apex/test/run.test.ts

-        expect(ctx.stderr).to.include(messages.getMessage('warningMessage'));
-      }
-    );
+    .command(['force:apex:test:run', '--tests', 'MyApexClass.testInsertTrigger', '--outputdir', outDir, '-r', 'human'])


Replacing 'my/path/to/dir' with outDir here is the change that was made to get the Windows unit tests passing. This is changed in 3 places. The rest of the changes in this file are prettier formatting changes.

klewis-sfdc · 2022-12-08T13:40:11Z

test/commands/force/apex/test/run.test.ts

 } from './testData';
+import { tmpdir } from 'os';
+
+const outDir = tmpdir();


Importing tmpdir and using it as the --outputdir value in the three tests below that were using 'my/path/to/dir' got the Windows unit tests passing on the GHA build.

.github/workflows/onRelease.yml

iowillhoit · 2022-12-09T20:52:00Z

.vscode/launch.json

+      "name": "Attach to Remote",
+      "address": "127.0.0.1",
      "port": 9229,
-      "skipFiles": ["<node_internals>/**"]


I don't know enough about this file's config. Is there a reason you removed skipFiles?

I must have added skip files while copying from elsewhere during dev. In the launch.json in the old monorepo, this configuration did not have the skipFiles property present: https://github.com/forcedotcom/salesforcedx-apex/blob/be31310f9ad92e8a13e876ad98efbab65b68463f/.vscode/launch.json#L10

iowillhoit · 2022-12-09T20:59:15Z

Could you please do a code search locally for salesforcedx and clean up those references.
Here is our "bugs" repo for the package.json: "bugs": "https://github.com/forcedotcom/cli/issues",

iowillhoit · 2022-12-09T21:27:54Z

You've got some failing actions because the compile scripts is not in your package.json. Here is a good list of default scripts for a plugin: https://github.com/salesforcecli/plugin-template-sf/blob/main/package.json#L84

iowillhoit · 2022-12-13T21:32:05Z

package.json

    "@salesforce/command": "^5.1.0",
    "@salesforce/core": "^3.23.3",
    "chalk": "^4.1.0",
    "tslib": "^1"


Update to tslib ^2 please

chg eslint rules to warn to commit

klewis-sfdc · 2023-01-10T21:10:54Z

I did some QA on this branch today:

Installed and built the apex-node library (after bumping the @salesforce/core dependency to "^3.32.12"
Linked the local apex-node lib to the plugin-apex lib locally (using the same version of core in the package.json of the plugin ("^3.32.12")
Linked the locally built plugin to the cli globally using sfdx plugins:link
Turned on logs, ran a deployment to the default scratch org, then ran sfdx force:apex:log:get -n 2, saw the logs get printed in the output ✅
Ran sfdx force:apex:log:list, saw the list of logs get printed in the output ✅
Ran sfdx force:apex:test:run ✅
- Then ran sfdx force:apex:test:report -i, saw Test Results reported in the output ✅
Ran sfdx force:apex:execute, saw the anonymous Apex get executed and the log get printed to the output ✅

klewis-sfdc · 2023-01-12T20:16:22Z

I bumped the version of @salesforce/core in the apex-node library so that it uses the same version as this library. I then updated this library to use the new version of apex-node, which is 1.6. This PR now builds successfully after a yarn install and yarn compile. I tested with these versions installed yesterday, and everything was looking good.

@iowillhoit Let me know if you see anything else that needs to be done before merging this PR and completing the handoff. Thanks for all of your help with this!

iowillhoit

Thanks Kenneth! I ran some QA too and things are looking great. Approving the PR, merge when you are are ready 🎉

chore: add github actions

db1f679

klewis-sfdc commented Nov 11, 2022

View reviewed changes

.github/CODEOWNERS Show resolved Hide resolved

klewis-sfdc force-pushed the ken/github-actions branch from d2de75c to db1f679 Compare November 16, 2022 23:45

update workflows to latest

3f99013

klewis-sfdc marked this pull request as draft November 17, 2022 00:11

klewis-sfdc and others added 23 commits November 16, 2022 16:15

add scripts

1d47d56

Revert "add scripts"

28080ab

This reverts commit 1d47d56.

Revert "update workflows to latest"

ed5e80f

This reverts commit 3f99013.

update workflows to latest

7d8f120

chore: remove the nuts tests

9b62510

this repo disnt have any and the action fails

chore: get format script working

d419feb

Revert "chore: remove the nuts tests"

845f9dd

This reverts commit 9b62510.

add nuts test script

fcf4171

add compile script

205a7eb

Update test.yml

d892053

Update test.yml

aa3a775

update test.yml only windows to isolate

e57bfea

set core to version in template repo

0492f81

Update test.yml

e060806

Revert "Update test.yml"

c8dea22

This reverts commit e060806.

chore: compile tests to make yarn test work

fa1882f

Update test.yml

048e0fa

Update test.yml

3b9fc14

chore: pickup top level tests in build

c731b82

chore: upd pkg json point at commands and format

ce8e2af

chore: safer chaining

ad0cad9

chore: add username flag to suppress errors

bbad2ff

chore: update yarn lock

0865b54

iowillhoit and others added 2 commits December 7, 2022 16:02

chore: add SWC and sync files

4d4b09e

Merge branch 'ew/swc' into ken/github-actions

1af8866

klewis-sfdc force-pushed the ken/github-actions branch from e95e5a6 to 1af8866 Compare December 7, 2022 22:53

chore: use tmpDir to fix windows failing tests

021f049

klewis-sfdc marked this pull request as ready for review December 7, 2022 23:04

klewis-sfdc commented Dec 8, 2022

View reviewed changes

chore: update Attach to Remote launch config

44b2f0c

iowillhoit reviewed Dec 9, 2022

View reviewed changes

.github/workflows/onRelease.yml Show resolved Hide resolved

iowillhoit reviewed Dec 9, 2022

View reviewed changes

iowillhoit reviewed Dec 13, 2022

View reviewed changes

klewis-sfdc and others added 9 commits December 13, 2022 13:33

chore: Update to tslib ^2

1b503bf

chore: add ctc to release workflow

a1bc4ab

chore: update bugs repo link

f378152

chore: add dev scripts and default pkg scripts

8efc132

chg eslint rules to warn to commit

chore: save results from format --fix

b60943f

chore: remove salesforcedx

b841c0e

chore: quotes

9c65b13

chore: update links in readme

05e1b75

fix: minor tweaks

d042508

iowillhoit and others added 2 commits January 10, 2023 16:54

chore: disable nuts

a83d6b3

feat: bump apexnode and core

7aa3f39

klewis-sfdc changed the title ~~chore: add github actions~~ feat: Add Github Actions and Update Dependency Versions Jan 12, 2023

iowillhoit approved these changes Jan 17, 2023

View reviewed changes

klewis-sfdc merged commit 9f27d5f into main Jan 17, 2023

iowillhoit deleted the ken/github-actions branch January 17, 2023 19:10

feat: Add Github Actions and Update Dependency Versions #2

feat: Add Github Actions and Update Dependency Versions #2

Uh oh!

Conversation

klewis-sfdc commented Nov 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What issues does this PR fix or reference?

Uh oh!

Uh oh!

randi274 commented Nov 15, 2022

Uh oh!

klewis-sfdc commented Nov 16, 2022

Uh oh!

klewis-sfdc Dec 8, 2022

Choose a reason for hiding this comment

Uh oh!

klewis-sfdc Dec 8, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iowillhoit Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

klewis-sfdc Dec 13, 2022

Choose a reason for hiding this comment

Uh oh!

iowillhoit commented Dec 9, 2022

Uh oh!

iowillhoit commented Dec 9, 2022

Uh oh!

iowillhoit Dec 13, 2022

Choose a reason for hiding this comment

Uh oh!

klewis-sfdc commented Jan 10, 2023

Uh oh!

klewis-sfdc commented Jan 12, 2023

Uh oh!

iowillhoit left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

klewis-sfdc commented Nov 11, 2022 •

edited

Loading