Skip to content

fix(deps): bump jsforce from 2.0.0-beta.20 to 2.0.0-beta.21#546

Merged
mshanemc merged 8 commits intomainfrom
dependabot-npm_and_yarn-jsforce-2.0.0-beta.21
Apr 27, 2023
Merged

fix(deps): bump jsforce from 2.0.0-beta.20 to 2.0.0-beta.21#546
mshanemc merged 8 commits intomainfrom
dependabot-npm_and_yarn-jsforce-2.0.0-beta.21

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Apr 22, 2023

I (@mshanemc) hijacked dependabot's PR because of some test failures. This PR now

bumps the jsforce dep, and sfdx-core
modifies the bulk nut to be less verbose with polling status
makes bin/dev act like the CLIs with how they use oclif/fush. Say more?

sf/sfdx have this pattern, which is now applied to this plugin's bin/dev

.then(function (result) {
    require('@oclif/core/flush')();
  })
  .catch(function (err) {
    require('@oclif/core/handle')(err);
  });

it was previously doing

oclif.run().then(require('@oclif/core/flush')).catch(require('@oclif/core/handle'));

the NUT was failing because sometimes one last promise would return with data after the command returns. I can't say exactly why that happens with newer jsforce, but I think it's related to differences between beta 20 and 21.

Either way, it produces an error on the oclif/flush code because it isn't expecting to be passed a value, but with the late-resolving promise, it is. Then all kinds of problems happen.

This would be fine in the CLIs (where flush was handled like this plugin does now) but this messed the NUTs up pretty bad even when they were getting the correct json response.

Bumps [jsforce](https://github.com/jsforce/jsforce) from 2.0.0-beta.20 to 2.0.0-beta.21.
- [Release notes](https://github.com/jsforce/jsforce/releases)
- [Changelog](https://github.com/jsforce/jsforce/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jsforce/jsforce/commits)

---
updated-dependencies:
- dependency-name: jsforce
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 22, 2023
@mshanemc mshanemc merged commit 7d8f9a9 into main Apr 27, 2023
@mshanemc mshanemc deleted the dependabot-npm_and_yarn-jsforce-2.0.0-beta.21 branch April 27, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant