fix(deps): bump jsforce from 2.0.0-beta.20 to 2.0.0-beta.21#546
Merged
fix(deps): bump jsforce from 2.0.0-beta.20 to 2.0.0-beta.21#546
Conversation
Bumps [jsforce](https://github.com/jsforce/jsforce) from 2.0.0-beta.20 to 2.0.0-beta.21. - [Release notes](https://github.com/jsforce/jsforce/releases) - [Changelog](https://github.com/jsforce/jsforce/blob/master/CHANGELOG.md) - [Commits](https://github.com/jsforce/jsforce/commits) --- updated-dependencies: - dependency-name: jsforce dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I (@mshanemc) hijacked dependabot's PR because of some test failures. This PR now
bumps the jsforce dep, and sfdx-core
modifies the bulk nut to be less verbose with polling status
makes bin/dev act like the CLIs with how they use oclif/fush. Say more?
sf/sfdx have this pattern, which is now applied to this plugin's bin/dev
it was previously doing
the NUT was failing because sometimes one last promise would return with data after the command returns. I can't say exactly why that happens with newer jsforce, but I think it's related to differences between beta 20 and 21.
Either way, it produces an error on the
oclif/flushcode because it isn't expecting to be passed a value, but with the late-resolving promise, it is. Then all kinds of problems happen.This would be fine in the CLIs (where flush was handled like this plugin does now) but this messed the NUTs up pretty bad even when they were getting the correct json response.