Skip to content

W-17672123 refactor: type-fix-for-result-format#1033

Merged
WillieRuemmele merged 4 commits intowr/soslfrom
sm/type-fix-for-result-format
Aug 13, 2024
Merged

W-17672123 refactor: type-fix-for-result-format#1033
WillieRuemmele merged 4 commits intowr/soslfrom
sm/type-fix-for-result-format

Conversation

@mshanemc
Copy link
Copy Markdown
Contributor

What does this PR do?

  • use oclif's Flags.custom to get a typed option flag that doesn't need ...spread to override the summary
  • explicitly disallow --result-format with --json

What issues does this PR fix or reference?

@mshanemc mshanemc requested a review from a team as a code owner August 13, 2024 13:55
@mshanemc mshanemc changed the title Sm/type-fix-for-result-format refactor: type-fix-for-result-format Aug 13, 2024
@WillieRuemmele WillieRuemmele merged commit b64a10e into wr/sosl Aug 13, 2024
@WillieRuemmele WillieRuemmele deleted the sm/type-fix-for-result-format branch August 13, 2024 14:31
WillieRuemmele added a commit that referenced this pull request Aug 13, 2024
* feat: add data search command

* chore: multiple object result

* chore: consolidate reporter classes

* test: add NUTs

* chore: gen snapshot

* refactor: move formatters to dirs, add UTs

* docs: provide way to override result-format summary

* write help for new "data search" command (#1026)

* fix: write the help for new command

* fix: add info about --result-format behavior

* chore: review reqs

* fix: write the help for new command

* fix: add info about --result-format behavior

* refactor: type-fix-for-result-format (#1033)

* refactor: use oclif custom flag

* refactor: exclusive json

* style: remove the word "results" from table heads

* test: no "Results" in test assertions

* test: fix NUT assertion

* chore: fix NUT

---------

Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
Co-authored-by: Juliet Shackell <juliet.shackell@salesforce.com>
Co-authored-by: mshanemc <shane.mclaughlin@salesforce.com>
@iowillhoit iowillhoit changed the title refactor: type-fix-for-result-format W-17672123 refactor: type-fix-for-result-format Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants