Skip to content

fix: respect maxQueryLimit config#306

Merged
cristiand391 merged 5 commits intomainfrom
cd/use-autoFetchQuery
May 26, 2022
Merged

fix: respect maxQueryLimit config#306
cristiand391 merged 5 commits intomainfrom
cd/use-autoFetchQuery

Conversation

@cristiand391
Copy link
Copy Markdown
Member

@cristiand391 cristiand391 commented May 26, 2022

What does this PR do?

Moves config agg logic from core into the plugin, also makes SoqlQuery return records emitted by jsforce instead of the full response.

Testing:

  1. link command into plugin-data

it should respect:
SFDX_MAX_QUERY_LIMIT env var
sfdx config:set maxQueryLimit=1 -g config

What issues does this PR fix or reference?

W-11204187

@cristiand391 cristiand391 changed the title fix: use autoFetchQuery fix: respect maxQueryLimit config May 26, 2022
@cristiand391
Copy link
Copy Markdown
Member Author

cristiand391 commented May 26, 2022

skipped UTs:
it.skip('should handle a simple query with all records returned in single call'
it.skip('should handle a query with a subquery' this is actually broken in latest-rc, the UT was just checking the json object which is correct, there's a bug in the table code.
Screen Shot 2022-05-26 at 19 38 19
it.skip('should handle empty query'
no error, blank output..


✅ respects maxQueryLimit setting:
✅ json output matches
Screen Shot 2022-05-26 at 19 44 12

✅ respects SFDX_MAX_QUERY_LIMIT env var
✅ json output matches
Screen Shot 2022-05-26 at 19 45 22

@cristiand391 cristiand391 merged commit e9bf141 into main May 26, 2022
@cristiand391 cristiand391 deleted the cd/use-autoFetchQuery branch May 26, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants