check for functions on org before creating compute env #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafreeman
force-pushed
the
cfreeman/functions-feature-wat
branch
from
ccdc11c to
195fd97
Compare
cafreeman
force-pushed
the
cfreeman/functions-feature-wat
branch
from
195fd97 to
9699adb
Compare
tevanoff
reviewed
May 13, 2021
src/commands/env/create/compute.ts
Outdated
|
|
||
| const conn = org.getConnection() | ||
|
|
||
| // This is a roundabout away of checking if a given org has Functions enabled. If they do NOT have functions enabled, |
Contributor
There was a problem hiding this comment.
Minor thing, but this is a lot of noise to check for an exceptional case. Maybe the command source would read better if this whole thing was extracted to a separate function.
Contributor
Author
There was a problem hiding this comment.
This is a good point. I'll update.
tevanoff
approved these changes
May 13, 2021
Contributor
tevanoff
left a comment
tevanoff
left a comment
There was a problem hiding this comment.
Left a minor nit, but not blocking 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07AH000000LicIYAS/view
Prior to this change, if you tried to create a compute environment associated with an org that did not have functions enabled, the API request would fail with an "Instance Not Found" error message. This is not helpful or informative, and proved to be a massive footgun for basically everyone who tried to use the CLI.
To remedy this, we now verify that the org being passed DOES have functions enabled before trying to create the compute environment. If it does not have functions enabled, we error out and display a helpful error message with instructions telling them what to do.
How to test
sfdx generate:project -n my_projectcd my_projectsfdx force:org:create -f config/project-scratch-def.json -a feature-scratch-orgsfdx env:create:compute -o feature-scratch-org