don't delete function references for other projects #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimen
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07AH000000MJTtYAO/view
We originally deleted references by simply deleting all function references that existed in the remote org but did not exist locally.
This works great if you only have a 1 project per org, but falls apart the second you have multiple projects pointing at the same org (you end up deleting all the functions for all the other projects 😬).
This PR fixes that by being more fine-grained when comparing the two sets of function refs and only comparing refs for the project you're currently working with.