W-22034567: remove startDate, endDate from license provision command and align json definition file fields with cli flags and enforce required flags#8
Conversation
| const messages = Messages.loadMessages('@salesforce/plugin-license-management', 'license.provision'); | ||
|
|
||
| type ProvisionLicenseSpec = { | ||
| namespace?: string; |
There was a problem hiding this comment.
This is a very minor discussion point.
@acardel
Do we want to try to "align" the field names between the CLI and the API?
There was a problem hiding this comment.
Agree, specially in the case of license which could refer to other types of licenses on the platform.
We should match license to permissionSetLicense
and namespace to namespacePrefix
What do you say @ukanoja-sf?
There was a problem hiding this comment.
The one thing we should probably be mindful of is not locking the sf cli command into PSL specific naming, since it is possible that this could be used for non-PSL related provisioning in the future.
So realistically, the only thing we might want to converge on is namespace.
tbh, it looks like the existing packaging code uses "namespace" as the parameter name.
So if we want to align to that, we'd be changing the API not the CLI.
Or we just let it go. Perhaps we ask Rashmi the importance of the delivery timing.
There was a problem hiding this comment.
I think after discussion with platform team we have decided to use just license and our design doc also mentions the same params. I prefer current naming and also not sure if we update now, then we might need another design review with platform team. If want to change, then I will prefer to update it in api request. @trey-sf, @acardel let me know if you prefer to discuss it over call (or tomorrow's standup) and we can quickly resolve it.
https://salesforce.quip.com/ysrEAiCWQfak#temp:C:YWc448cff01faa74dc0b48f1cf93
There was a problem hiding this comment.
saw @trey-sf's comment after posting my comment, I will bring this up in tomorrow's stand up and we can close this in parking lot.
There was a problem hiding this comment.
Cool. If that's the case I lean towards letting it go. I like the API to be PSL specific. If a user goes straight to the endpoint they will be hitting the PermissionSetLicense resource.
There was a problem hiding this comment.
I'd definitely leave PermissionSetLicense as-is.
It's whether we rename "namespacePrefix" to just "namespace" in the API.
Let's discuss in PL.
3 participants
What does this PR do?
What issues does this PR fix or reference?
GUS: @W-22034567@
Local testing