Skip to content

Conversation

@peternhale
Copy link
Contributor

@W-11976036@
removed force as the top-level topic
add aliases back to original command
add flag aliases to maintain backward compatibility
sort sobjects by name

@W-11976036@
removed force as the top-level topic
add aliases back to original command
add flag aliases to maintain backward compatibility
sort sobjects by name
@peternhale peternhale requested a review from mshanemc November 11, 2022 20:35
Copy link
Contributor

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also have Matt review for sf naming conventions

@peternhale peternhale requested a review from mshanemc November 14, 2022 22:37
@mattgraham
Copy link

mattgraham commented Nov 16, 2022

@mshanemc we talked after @peternhale and I met and you mentioned you were not a fan of sf org list api-limits. Do we have thoughts on a better alternative? cc @mdonnalley keeping to the [product/service] [action] [resource] model.

@peternhale
Copy link
Contributor Author

@mshanemc we talked after @peternhale and I met and you mentioned you were not a fan of sf org list api-limits. Do we have thoughts on a better alternative? cc @mdonnalley keeping to the [product/service] [action] [resource] model.

@mattgraham who is not a fan?

@peternhale peternhale merged commit 28b6c4e into main Nov 17, 2022
@peternhale peternhale deleted the phale/W-11976036-parity branch November 17, 2022 14:29
mshanemc added a commit that referenced this pull request Nov 17, 2022
@mshanemc
Copy link
Contributor

@mshanemc we talked after @peternhale and I met and you mentioned you were not a fan of sf org list api-limits. Do we have thoughts on a better alternative? cc @mdonnalley keeping to the [product/service] [action] [resource] model.

@mattgraham who is not a fan?

sf org list limits is better (API limits are just one of the many rows it displays).

My other concern is sf org list "covering" this up making it harder to find or access. sf org get limits sounds good to me since this is just a retrieve from that api.

mshanemc added a commit that referenced this pull request Nov 17, 2022
@mattgraham
Copy link

@mshanemc we talked after @peternhale and I met and you mentioned you were not a fan of sf org list api-limits. Do we have thoughts on a better alternative? cc @mdonnalley keeping to the [product/service] [action] [resource] model.

@mattgraham who is not a fan?

sf org list limits is better (API limits are just one of the many rows it displays).

My other concern is sf org list "covering" this up making it harder to find or access. sf org get limits sounds good to me since this is just a retrieve from that api.

Just for continued conversation knowing this has merged and that we can update as we find the best method for the overall sf pattern: I do like the idea of sf org list limits showing your org limits in table form:

Description Limit Period
API 890/1,000 24 Hour
SOQL Queries 60/100 24 Hour
SOQL Records 34,000/50,000 24 Hour

then we myabe we add filters in addition to them. Possibly sf org list limits api or sf org list limits:api. Thoughts?

@peternhale
Copy link
Contributor Author

The merge was reverted so this is still open for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants