Skip to content

fix: parking orbit plugin-limits #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 1, 2022
Merged

fix: parking orbit plugin-limits #254

merged 6 commits into from
Apr 1, 2022

Conversation

@WillieRuemmele
Copy link
Contributor

@WillieRuemmele WillieRuemmele commented Mar 25, 2022

What does this PR do?

parking-orbits plugin-limits using core3/command5

What issues does this PR fix or reference?

@W-10743845@

@iowillhoit
Copy link
Contributor

iowillhoit commented Apr 1, 2022 •
edited
Loading

QA Notes

🔴 There a few SFDXError instances that need replaced
↳ Updated 🟢

force:limits:api:display

🟢 Displays limits

force:limits:api:display --json

🟢 JSON matches exactly

bs force:limits:api:display -u test-mckmlvcpuupv@example.com (session expired)

🟢 Shows "Session expired or invalid" error
🟢 JSON contract matches

bs force:limits:api:display -u test-not-a-user@example.com

🟢 Shows "No authorization information found" error
🟢 JSON contract matches

bs force:limits:api:display -u test-mckmlvcpuupv@example.com (not the default user)

🟢 Displays limits for non-defaul user
🟢 JSON contract matches

force:limits:api:display --apiversion 53.0

🟢 Can set apiversion

force:limits:recordcounts:display

🟢 Missing required flag error
🟢 JSON error contract matches

force:limits:recordcounts:display -s Account

Tested with Dreamhouse

NOTE: This takes quite a while for values to appear. At least an hour?

# setup
sfdx force:org:create -s -f config/project-scratch-def.json
sfdx force:source:push
sfdx force:user:permset:assign -n Dreamhouse
sfdx force:data:tree:import --plan data/sample-data-plan.json

# run command
sfdx force:limits:recordcounts:display -s Contact,Broker__c,Property__c

🟢 Lists single record (Account)
🟢 Lists multiple records (Account,ListView,Prompt)
🟢 JSON contract matches
🟢 SObjects that are not found show count: 0
🟢 Works passing in a (non-default) username

@iowillhoit iowillhoit self-assigned this Apr 1, 2022
iowillhoit
iowillhoit reviewed Apr 1, 2022
View reviewed changes
messages/recordcounts.json Outdated
@@ -1,6 +1,7 @@
{
"commandDescription": "display record counts for the specified standard and custom objects\nUse this command to get an approximate count of the records in standard or custom objects in your org. These record counts are the same as the counts listed in the Storage Usage page in Setup. The record counts are approximate because they're calculated asynchronously and your org’s storage usage isn’t updated immediately.",
"commandDescription": "display record counts for the specified standard and custom objects\nUse this command to get an approximate count of the records in standard or custom objects in your org. These record counts are the same as the counts listed in the Storage Usage page in Setup. The record counts are approximate because they're calculated asynchronously and your org's storage usage isn't updated immediately. Executing without the '--sobjecttype' flag will display all available record counts.",
Copy link
Contributor

@iowillhoit iowillhoit Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jshackell-sfdc this look ok?

jshackell-sfdc
jshackell-sfdc reviewed Apr 1, 2022
View reviewed changes
iowillhoit and others added 2 commits April 1, 2022 12:16
@iowillhoit @jshackell-sfdc
Update messages/recordcounts.json
6e95d02 
Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
@iowillhoit
chore: command bump
92ea213
@iowillhoit iowillhoit merged commit 2924569 into main Apr 1, 2022
@iowillhoit iowillhoit deleted the wr/parkingOrbit branch April 1, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iowillhoit iowillhoit iowillhoit approved these changes

@jshackell-sfdc jshackell-sfdc jshackell-sfdc left review comments

Assignees

@iowillhoit iowillhoit

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WillieRuemmele @iowillhoit @jshackell-sfdc