Skip to content

Conversation

@sf-aastha-paruthi
Copy link
Collaborator

What does this PR do?

What issues does this PR fix or reference?

@sf-aastha-paruthi sf-aastha-paruthi requested a review from a team as a code owner August 18, 2025 16:06
diff: JSON.stringify([]),
hasOmnistudioContent: false,
status: 'Ready for migration',
status: type === this.ASSESS ? 'Ready for migration' : 'Complete',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this particular change is conflicts with latest changes of @snehaljha-sf

https://github.com/salesforcecli/plugin-omnistudio-migration-tool/pull/383/files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete --> Successfully migrated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the PR is still open, this can be taken up as part of merge conflicts.
Uploading image.png…

postMigrate.deploy();
} catch (error) {
Logger.error(messages.getMessage('errorDeployingComponents'), error);
Logger.logVerbose(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we logging error twice here?

Copy link
Contributor

@sf-kishore-kurri sf-kishore-kurri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


experienceSiteAssessmentInfo.status =
experienceSiteAssessmentInfo.warnings && experienceSiteAssessmentInfo.warnings.length > 0
? 'Needs Manual Intervention'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For migration status should be skipped

@snehaljha-sf snehaljha-sf merged commit e02ee85 into salesforcecli:prerelease/develop-ga Aug 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants