-
Notifications
You must be signed in to change notification settings - Fork 11
@W-18480454 Bugfix - Experience sites are not part of package.xml #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-18480454 Bugfix - Experience sites are not part of package.xml #382
Conversation
| diff: JSON.stringify([]), | ||
| hasOmnistudioContent: false, | ||
| status: 'Ready for migration', | ||
| status: type === this.ASSESS ? 'Ready for migration' : 'Complete', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this particular change is conflicts with latest changes of @snehaljha-sf
https://github.com/salesforcecli/plugin-omnistudio-migration-tool/pull/383/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete --> Successfully migrated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| postMigrate.deploy(); | ||
| } catch (error) { | ||
| Logger.error(messages.getMessage('errorDeployingComponents'), error); | ||
| Logger.logVerbose(error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we logging error twice here?
sf-kishore-kurri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| experienceSiteAssessmentInfo.status = | ||
| experienceSiteAssessmentInfo.warnings && experienceSiteAssessmentInfo.warnings.length > 0 | ||
| ? 'Needs Manual Intervention' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For migration status should be skipped
e02ee85
into
salesforcecli:prerelease/develop-ga
What does this PR do?
What issues does this PR fix or reference?