fix: @W-19637353: Prudential Migration issues #414
Conversation
Changes: - Hanlded the error case for DM data migration issues - IP having custom formula causing the JSON parse issue - Hanlde of LWC component with nested namespace tags
sf-kishore-kurri
force-pushed
the
u/kkurri/W-19637353
branch
from
c1168ba to
a38e397
Compare
| } else { | ||
| // Handle failed migration - add error information | ||
| if (!drUploadResponse) { | ||
| if (!drUploadResponse?.success) { |
There was a problem hiding this comment.
Why are we removing the undefined check?
There was a problem hiding this comment.
We aren't removing, we are checking the success status and logging error for failure case
| Logger.warn( | ||
| this.messages.getMessage('elementValueMapUnexpectedType', [ | ||
| typeof propertySet.elementValueMap, | ||
| ipElement['Name'] || 'Unknown', |
There was a problem hiding this comment.
Should the code not return from here, if the elementValueMap is of unexpectedType?
There was a problem hiding this comment.
If elementValueType is undefined then we don't update the config and move on with existing
There was a problem hiding this comment.
If this condition is false
typeof propertySet.elementValueMap === 'object') still the line 847 will be hit
I meant elementValueMapUnexpectedType.
| formulasUpdated = true; | ||
| Logger.logVerbose(`Updated formula in ${key}: ${value} -> ${updatedFormula}`); | ||
| } | ||
| } catch (formulaEx) { |
There was a problem hiding this comment.
In case of exception/ failure to update the formula, how will the same be reflected in the report, if we are catching the exceptions
There was a problem hiding this comment.
When update formula function fails, we are logging error and verbose message for debugging and managed package runtime will do the formula migration again post migration so we should be good
There was a problem hiding this comment.
If the managed package will do it and we are sure, then why are we duplicating the logic?
There was a problem hiding this comment.
It is the existing logic with OMT tool
snehaljha-sf
merged commit e0978be
into
salesforcecli:prerelease/develop-ga
3 participants
Changes:
What does this PR do?
What issues does this PR fix or reference?