fix: org list now lists all scratch orgs properly #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
commented
Jul 28, 2022
| const orgFileContent = JSON.parse( | ||
| await fs.readFile(join(Global.SFDX_STATE_FOLDER, orgFileName), 'utf8') | ||
| ) as { usernames: string[] }; | ||
| const orgFileContent = JSON.parse(await fs.readFile(join(Global.SFDX_DIR, orgFileName), 'utf8')) as { |
Contributor
Author
There was a problem hiding this comment.
Global.SFDX_STATE_FOLDER is a const, where Global.SFDX_DIR is a getter that resolved the state folder path. The cost was causing all reads to fail with file not found.
mshanemc
approved these changes
Jul 28, 2022
fix: bump salesforce/core
Contributor
|
QA notes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the path when reading user json file when the org is referenced in a
00Dfile.What issues does this PR fix or reference?
@W-11507149@
forcedotcom/cli#1641