chore: add nut tests for plugin-org #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
requested review from
WillieRuemmele,
mdonnalley,
mshanemc and
shetzel
mshanemc
approved these changes
Mar 9, 2021
Contributor
mshanemc
left a comment
mshanemc
left a comment
There was a problem hiding this comment.
approved with comments. The only one I have strong feelings about it the weird import/require change
| const result = execCmd('force:org:list --skipconnectionstatus --json'); | ||
| expect(result.shellOutput.code).to.be.equal( | ||
| 0, | ||
| concatString(result.shellOutput.stdout, result.shellOutput.stderr) |
Contributor
There was a problem hiding this comment.
This does produce nicer messages from mocha on fails. Does this belong in testkit so Pete doesn't have to boilerplate it? @shetzel
shetzel
approved these changes
Mar 9, 2021
Contributor
shetzel
left a comment
shetzel
left a comment
There was a problem hiding this comment.
Looks good! 1 non-blocking comment.
Windows tests are failing becuase stdout is not being parsed to lines using os.EOL
shetzel
approved these changes
Mar 9, 2021
mshanemc
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new nut tests for plugin-org
What issues does this PR fix or reference?
@W-8856585@