@W-21768097 Block sf package convert calls outside of sfdx project directory#1160
Merged
iowillhoit merged 3 commits intomainfrom Apr 9, 2026
Merged
Conversation
ravipanguluri
force-pushed
the
t/2gp-readiness/w-21768097/block-conversion-not-in-project
branch
from
66e4c78 to
83ccd8d
Compare
luop90
reviewed
Apr 9, 2026
| public static readonly examples = messages.getMessages('examples'); | ||
| public static readonly deprecateAliases = true; | ||
| public static readonly aliases = ['force:package:convert']; | ||
| public static readonly requiresProject = true; |
Collaborator
There was a problem hiding this comment.
Is this boolean actually doing anything? I don't see it referenced in your PR besides the unit test
Collaborator
Author
There was a problem hiding this comment.
It's used within logic that's in the sf-plugins-core. When the parameter is true, then during the command initialization we attempt to resolve an sf project directory from the current working directory. If it doesn't exist then an error is thrown. This does bring up that the point that the unit test is not particularly useful.
luop90
approved these changes
Apr 9, 2026
iowillhoit
approved these changes
Apr 9, 2026
iowillhoit
deleted the
t/2gp-readiness/w-21768097/block-conversion-not-in-project
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets the requiresProject field to true for the convert command via the CLI so that users fail fast when trying to convert outside of a sfdx-project directory. Before customers were receiving an ambiguous error that was not indicative of the true nature of the issue.
What issues does this PR fix or reference?
See @W-21768097@