Skip to content

feat: remove outdated version create message#863

Merged
shetzel merged 1 commit intosalesforcecli:mainfrom
kyle-blair:remove-old-message
Mar 21, 2025
Merged

feat: remove outdated version create message#863
shetzel merged 1 commit intosalesforcecli:mainfrom
kyle-blair:remove-old-message

Conversation

@kyle-blair
Copy link
Copy Markdown
Contributor

@kyle-blair kyle-blair commented Dec 27, 2024

What does this PR do?

Removes an old message about code coverage requirements for promoting unlocked package versions. The information is several years old.

What issues does this PR fix or reference?

It was a simple enough change that I didn't bother opening an issue.

@kyle-blair kyle-blair requested a review from a team as a code owner December 27, 2024 22:22
@shetzel
Copy link
Copy Markdown
Contributor

shetzel commented Mar 20, 2025

@kyle-blair - Turns out there is a test that looks for this message. If you'd like to get credit for this PR (rather than me making the change and getting the credit) can you remove that check here: plugin-packaging/test/commands/package/versionPromoteUpdate.nut.ts:51

@kyle-blair
Copy link
Copy Markdown
Contributor Author

@kyle-blair - Turns out there is a test that looks for this message. If you'd like to get credit for this PR (rather than me making the change and getting the credit) can you remove that check here: plugin-packaging/test/commands/package/versionPromoteUpdate.nut.ts:51

Sorry about that @shetzel, I had issues with the yarn install and therefore didn't notice the test. I rebased to upstream main and squashed the test update into a single commit. Is the unsigned commit an issue? I don't have signing set up on this computer yet, but I can replace the commit with a signed one tomorrow if necessary. Thanks for taking a look!

@shetzel shetzel merged commit 4752cb2 into salesforcecli:main Mar 21, 2025
14 checks passed
@kyle-blair kyle-blair deleted the remove-old-message branch April 23, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants