Skip to content

fix: parking orbit plugin-schema#217

Merged
iowillhoit merged 6 commits into
mainfrom
wr/parkingOrbit
Apr 6, 2022
Merged

fix: parking orbit plugin-schema#217
iowillhoit merged 6 commits into
mainfrom
wr/parkingOrbit

Conversation

@WillieRuemmele
Copy link
Copy Markdown
Contributor

What does this PR do?

parking-orbit for plugin-schema using command5/core3/oclif-core

What issues does this PR fix or reference?

@W-10743871@

@iowillhoit
Copy link
Copy Markdown
Contributor

QA Notes

🟡 Bump command to 5.0.4

force:schema or force:schema:sobject

🔴 Running incomplete command does not suggest Topics or Commands

Before

$ sfdx force:schema:sobject
view standard and custom objects

USAGE
  $ sfdx force:schema:sobject:COMMAND

COMMANDS
  force:schema:sobject:describe  displays the metadata for a standard or custom object
  force:schema:sobject:list      list all objects of a specified category

After

$ sfdx force:schema:sobject
view standard and custom objects

USAGE
  $ sfdx force:schema:sobject:COMMAND

force:schema:sobject:list

🔴 Command not found

$ sfdx force:schema:sobject:list
 ›   Warning: force:schema:sobject:list is not a sfdx command.

force:schema:sobject:display

🔴 Command not found

$ sfdx force:schema:sobject:display
 ›   Warning: force:schema:sobject:display is not a sfdx command.

@iowillhoit
Copy link
Copy Markdown
Contributor

Well I have no idea what was going on... I reinstalled some things and it is working fine now 🤷

New Notes, everything looks great!

force:schema:sobject:list --help and -h

🟢 Short and long help works

force:schema:sobject:list

🟢 Returns all sobjects by default

force:schema:sobject:list --json

🟢 JSON contract matches

force:schema:sobject:list --targetusername A_NON_DEFAULT_USERNAME

🟢 Works as expected

force:schema:sobject:list --apiversion 53.0

🟢 Works as expected

force:schema:sobject:list ----sobjecttypecategory foo --json

🟢 Throws error on invalid --sobjecttypecategory

force:schema:sobject:list ----sobjecttypecategory standard --json

🟢 Displays standard sobjects

force:schema:sobject:list ----sobjecttypecategory custom --json

🟢 Shows "No CUSTOM objects found"
🟢 JSON contract matches

force:schema:sobject:list -c custom

🟢 Successfully lists created custom objects
🟢 JSON contract matches

force:schema:sobject:describe -s Testing_Custom__c --json

🟢 Shows output for custom object
🟢 JSON contract matches

force:schema:sobject:describe -s Testing_Custom__c

🟢 Shows output for custom object
🟢 Output is just json without the top level status and result

force:schema:sobject:describe -s foo

🟢 Errors with non-existing sobject
🟢 JSON error contract matches

force:schema:sobject:display -s WorkThanks

🟢 Shows output for standard object

force:schema:sobject:display -s WorkThanks --targetusername A_NON_DEFAULT_USERNAME

🟢 Works as expected

force:schema:sobject:describe -s WorkThanks --apiversion 53.0

🟢 Can change apiversion

force:schema:sobject:describe -s ApexClass --usetoolingapi

🟢 Can use the toolingapi
🟢 JSON contract matches

@iowillhoit iowillhoit merged commit ec8e27f into main Apr 6, 2022
@iowillhoit iowillhoit deleted the wr/parkingOrbit branch April 6, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants