Skip to content

feat: warning label for source:open #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristiand391 merged 2 commits into from
Sep 29, 2021
Merged

feat: warning label for source:open #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
626eb2a
feat: warning label for source:open
mshanemc Sep 29, 2021
f4a4de0
test: remote testProj
mshanemc Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion messages/open.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@
"SourceOpenPathDescription": "generate a navigation URL; don’t launch the editor",
"SourceOpenCommandHumanSuccess": "Access org %s as user %s with the following URL: %s",
"SourceOpenCommandTimeoutError": "Timeout error",
"SourceOpenCommandError": "Open failed"
"SourceOpenCommandError": "Open failed",
"SecurityWarning": "This command will expose sensitive information that allows for subsequent activity using your current authenticated session.\nSharing this information is equivalent to logging someone in under the current credential, resulting in unintended access and escalation of privilege.\nFor additional information, please review the authorization section of the https://developer.salesforce.com/docs/atlas.en-us.234.0.sfdx_dev.meta/sfdx_dev/sfdx_dev_auth_web_flow.htm"
}
2 changes: 2 additions & 0 deletions src/formatters/openResultFormatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ export class OpenResultFormatter extends ResultFormatter {

public display(): void {
if (this.isSuccess()) {
this.ux.warn(messages.getMessage('SecurityWarning'));
this.ux.log();
const { orgId, username, url } = this.result;
this.ux.log(messages.getMessage('SourceOpenCommandHumanSuccess', [orgId, username, url]));
} else {
Expand Down