Skip to content
This repository was archived by the owner on Mar 25, 2026. It is now read-only.

Sm/fix stl jsforce autofetch#515

Merged
mshanemc merged 17 commits intomainfrom
sm/fix-stl-jsforce-autofetch
Jun 23, 2022
Merged

Sm/fix stl jsforce autofetch#515
mshanemc merged 17 commits intomainfrom
sm/fix-stl-jsforce-autofetch

Conversation

@mshanemc
Copy link
Copy Markdown
Contributor

@mshanemc mshanemc commented Jun 16, 2022

requires forcedotcom/source-tracking#175

What does this PR do?

fix jsforce2 autofetch issues like plugin data did salesforcecli/plugin-data#316
restores the async deploy nuts (the ones that use source-testkit)
handles cancellations better when the deploy succeeds too quickly to cancel

fixes these class of errors in the async deploy nuts : https://app.circleci.com/pipelines/github/salesforcecli/plugin-source/3910/workflows/a6053ee7-ef2d-43f2-a945-39ec6a74c920/jobs/34514 (records returning after mocha exits)
which you'll probably see in the async nuts on this repo

What issues does this PR fix or reference?

@W-11309357@

QA: the only place I've confirmed this causes problems is in the async NUTs, but there's potential this affects sourceMember polling (it quits before getting all the sourceMembers) leaving tracking files in a wrong state.

You can confirm the fix by linking STL locally (that's why the temporary tsconfigs are included) and then running the async nuts.

I don't know how else to reliably get the error.

Shipping

  1. release STL with this fix: Sm/autofetch bug forcedotcom/source-tracking#175
  2. bump STL in plugin-source
  3. remove the core and SDR entries in tsconfig and test/tsconfig. You'll need them for local/link testing until the STL fix is in
  4. push those changes up. At this point, async nuts should pass and most others should be ok, too.

@mshanemc mshanemc merged commit 750633f into main Jun 23, 2022
@mshanemc mshanemc deleted the sm/fix-stl-jsforce-autofetch branch June 23, 2022 03:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants