This repository was archived by the owner on Mar 25, 2026. It is now read-only.
Merged
Conversation
…ecli/plugin-source into sm/nuts-race-condition
shetzel
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix jsforce2 autofetch issues like plugin data did salesforcecli/plugin-data#316
restores the async deploy nuts (the ones that use source-testkit)
handles cancellations better when the deploy succeeds too quickly to cancel
fixes these class of errors in the async deploy nuts : https://app.circleci.com/pipelines/github/salesforcecli/plugin-source/3910/workflows/a6053ee7-ef2d-43f2-a945-39ec6a74c920/jobs/34514 (records returning after mocha exits)
which you'll probably see in the async nuts on this repo
What issues does this PR fix or reference?
@W-11309357@
QA: the only place I've confirmed this causes problems is in the async NUTs, but there's potential this affects sourceMember polling (it quits before getting all the sourceMembers) leaving tracking files in a wrong state.
You can confirm the fix by linking STL locally (that's why the temporary tsconfigs are included) and then running the async nuts.
I don't know how else to reliably get the error.
Shipping