Skip to content

feat: adds allow-list commands#1223

Open
jamessimone wants to merge 4 commits intosalesforcecli:mainfrom
jamessimone:main
Open

feat: adds allow-list commands#1223
jamessimone wants to merge 4 commits intosalesforcecli:mainfrom
jamessimone:main

Conversation

@jamessimone
Copy link
Copy Markdown

What does this PR do?

Adds commands for interacting with the allow-list, including the creation of the allow-list if it doesn't already exist. My team realized recently that we were creating our allow-list on the wrong path in CI, leading to some confusion and some duplicated --no-prompt or echo y | sf plugins install ... commands over the years.

I also added mocha properly to the tsconfig.json file, as without that, VS Code will lint the mocha global usage in tests as an error.

Copy link
Copy Markdown
Contributor

@jshackell-sfdc jshackell-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm the CLI writer. The --help looks great! But I added a few suggestions, let me know if you have any questions.

Comment thread messages/allow-list.add.md Outdated
Comment thread messages/allowlist.add.md
Comment thread messages/allow-list.add.md Outdated
Comment thread messages/allow-list.add.md Outdated
Comment thread messages/allow-list.add.md Outdated
Comment thread messages/allow-list.remove.md Outdated
Comment thread messages/allow-list.remove.md Outdated
Comment thread messages/allow-list.remove.md Outdated
Comment thread messages/allow-list.remove.md Outdated
Comment thread messages/allow-list.remove.md Outdated
Updating with @jshackell-sfdc feedback

Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
@jamessimone
Copy link
Copy Markdown
Author

@jshackell-sfdc thanks so much for your review. I've updated with your feedback - however, in thinking about the changes to --help, I'm left wondering if I shouldn't also update the command itself to be known as allowlist versus what I currently have it authored as (allow-list). What do you think?

@jshackell-sfdc
Copy link
Copy Markdown
Contributor

jshackell-sfdc commented Apr 6, 2026

Yes, we actually talked about this in standup today! I think @mitchspano was going to comment about the topic name (I think he liked allowlist rather than allow-list) but until he weighs in, I agree - allowlist is preferred from my POV. Thank you!

(and in this context, allowlist is the topic name. :) )

@jamessimone
Copy link
Copy Markdown
Author

@jshackell-sfdc I spoke with Mitch and we aligned on allowlist so I made those updates and pushed them up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants