feat: adds allow-list commands#1223
Conversation
jshackell-sfdc
left a comment
There was a problem hiding this comment.
I'm the CLI writer. The --help looks great! But I added a few suggestions, let me know if you have any questions.
Updating with @jshackell-sfdc feedback Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
|
@jshackell-sfdc thanks so much for your review. I've updated with your feedback - however, in thinking about the changes to |
|
Yes, we actually talked about this in standup today! I think @mitchspano was going to comment about the topic name (I think he liked (and in this context, |
|
@jshackell-sfdc I spoke with Mitch and we aligned on |
What does this PR do?
Adds commands for interacting with the allow-list, including the creation of the allow-list if it doesn't already exist. My team realized recently that we were creating our allow-list on the wrong path in CI, leading to some confusion and some duplicated
--no-promptorecho y | sf plugins install ...commands over the years.I also added
mochaproperly to thetsconfig.jsonfile, as without that, VS Code will lint the mocha global usage in tests as an error.