fix: fail immediately when --url is unreachable instead of 60s timeout @W-21331028@#31
Merged
deepu-mungamuri94 merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
…t @W-21331028@ - When --url is provided and unreachable, fail immediately with clear error - Add error.dev-url-unreachable-with-flag message for --url case - Suggests removing --url to use dev.command when user has manifest config Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates sf webapp dev so that when --url is passed with an unreachable URL, the command fails immediately instead of starting the dev server and waiting 60 seconds for a timeout. It also adds a clearer error message for this case that suggests removing --url to use dev.command when the manifest already has dev config.
What issues does this PR fix or reference?
@W-21331028@