Add queue support for Barstool recordings#1
Conversation
…fety and improve test assertions for job payloads.
craigpotter
left a comment
There was a problem hiding this comment.
Looks great, thanks for this @niladam
Just one small change
…ed tests and logic for consistency.
So, while i was resolving your suggestion i realised that Also, ran a quick We should be good to go :) |
|
Also, sorry for spamming this, but i didn't touch CHANGELOG thinking you're auto-generating it. If that's not the case we should probably update that as well :) |
No worries @niladam. This is looking good. No need to worry about the change log, I'll handle this. I will give it and quick blast this evening and if all good - I'll release and tag a new version. |
You're welcome! |
First and foremost thank you for this! Good job!
I personally, have a user-land implementation of something similar which i've built for my own personal use and because of this, i know that i don't want my requests to be affected and therefore i personally use jobs. I think it makes sense to have this as an option in this package as well, as i plan to essentially deprecate my user-land implementation in favor of this.
Also, i think that this doesn't affect the current functionality and it only adds to it's functionality :)