Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

Conversation

@Sammyjo20
Copy link
Member

@Sammyjo20 Sammyjo20 commented Mar 14, 2023

This PR fixes an issue where any additional Guzzle configuration items that were sent including ones that were added by authenticator methods like the withBasicAuth would get overwritten in the HttpSender class.

Fixes #7

Copy link
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 changed the title Fix| Fixed issue with guzzle config options not sent Fix | Fixed issue with guzzle config options not sent Mar 14, 2023
@Sammyjo20 Sammyjo20 changed the title Fix | Fixed issue with guzzle config options not sent Fix | Fixed issue with guzzle config options not being sent Mar 14, 2023
@Sammyjo20 Sammyjo20 merged commit 5ccae27 into main Mar 14, 2023
@Sammyjo20 Sammyjo20 deleted the fix/guzzle-config-options-not-sent branch September 13, 2023 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Basic Auth not working

2 participants