Merged
Conversation
|
Member
Author
|
@derheyne Let me know if you're happy with this and I'll roll it out |
|
Looks good to me! Thank you so much for the fast implementation :) Before you merge it let me quickly test it against our code base. |
|
Works perfectly in our code base! |
Member
Author
|
Great thank you for testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue which was raised in discussion #148 where if a request returned a downloadable file, the fixture could not be recorded because it threw an exception "Malformed UTF-8 characters, possibly incorrectly encoded"
@derheyne Came up with a brilliant idea to
base64_encode()the response body if it cannot detect UTF-8 encoding. This is also backwards compatible because of the addedencodingoption.