Add default defineEndpoint in base SaloonRequest#21
Merged
Sammyjo20 merged 1 commit intosaloonphp:mainfrom Jan 29, 2022
Merged
Conversation
Sammyjo20
approved these changes
Jan 29, 2022
Member
Sammyjo20
left a comment
There was a problem hiding this comment.
This is a great little improvement! 🙌 Glad it is working well for GraphQL
Thank you for the PR ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just got started with this for a graphql integration, works really good 💫
Not 100% sure this is an improvement you would like so feel free to decline it 👍
Since graphql request always targets a root like "www.acme.com/api/graphql" - no appended endpoint - would it make sense to allow to not explicitly repeating defineEndpoint method returning '' every time?
This PR adds the above to the base class as a default.
Also let me know if you prefer keeping all tests in function block style. I just discovered that higher order thing 😄