Skip to content

Feature | Spring cleaning & added authentication alias#63

Merged
Sammyjo20 merged 3 commits intov1from
feature/authentication-alias
Jun 10, 2022
Merged

Feature | Spring cleaning & added authentication alias#63
Sammyjo20 merged 3 commits intov1from
feature/authentication-alias

Conversation

@Sammyjo20
Copy link
Copy Markdown
Member

This PR is just some nice spring cleaning, making sure all requests/connectors return "static" and not "self" to improve developer experience, and also added an alias so now you can write:

$request = new GetForgeServersRequest;
$request->authenticate($auth);

Copy link
Copy Markdown
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review complete

@Sammyjo20 Sammyjo20 marked this pull request as ready for review June 10, 2022 20:31
@Sammyjo20 Sammyjo20 merged commit 82a4569 into v1 Jun 10, 2022
@Sammyjo20 Sammyjo20 deleted the feature/authentication-alias branch June 11, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant