fix response DTO type-hint#85
Merged
Sammyjo20 merged 1 commit intosaloonphp:v1from Oct 7, 2022
Gummibeer:patch-1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native type-hint is
mixed- like everywhere else - but the php-doc type-hint saysobject|nullwhich will be true in most cases but it's possible andmixedallows it to also return a scalar value.Even if it's not the primary/intended use case the whole package allows to return of a single scalar value.
This is helpful for APIs which also only return a single value - like success, number of something or similar.
For example the @ecologi public reporting API:
This PRsadjusts the php-doc type to match the native one. And solves phpstan errors like the following:
I assume that this fix should also be applied to the v2 - but haven't checked yet if this problem still exists.