Require interned structs' fields to be Update
#1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
ChayimFriedman2
force-pushed
the
update-interned
branch
from
b2989cc to
fb38d5a
Compare
CodSpeed Performance ReportMerging #1036 will not alter performanceComparing Summary
|
Veykril
reviewed
Dec 16, 2025
Veykril
approved these changes
Dec 16, 2025
Contributor
|
Does this fix #985 Can we add two non-compile tests:
|
Contributor
Author
Yes.
I added them as one, except storing a lifetime'd struct instead of a reference. |
ChayimFriedman2
force-pushed
the
update-interned
branch
from
fb38d5a to
eaeff14
Compare
To fix an unsoundness - salsa-rs#985. There are two breaking changes here: 1. Interned fields and interned function fields are required to be `Update` (or `'static`) 2. `unsafe(non_update_return_types)` in tracked fn options was renamed to `unsafe(non_update_types)` (and includes interned parameters as well now).
ChayimFriedman2
force-pushed
the
update-interned
branch
from
eaeff14 to
0f5be17
Compare
Contributor
Author
|
Addressed comments. |
Contributor
Author
|
Can we get a release with this please? It's needed for rust-analyzer. |
ChayimFriedman2
added a commit
to ChayimFriedman2/salsa
that referenced
this pull request
Dec 16, 2025
ChayimFriedman2
added a commit
to ChayimFriedman2/salsa
that referenced
this pull request
Dec 16, 2025
ChayimFriedman2
added a commit
to ChayimFriedman2/salsa
that referenced
this pull request
Dec 16, 2025
This was referenced Dec 16, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix an unsoundness - #985.
There are two breaking changes here:
Update(or'static)unsafe(non_update_return_types)in tracked fn options was renamed tounsafe(non_update_types)(and includes interned parameters as well now).Fixes #985.