Deprecate localClassNames and friends
#241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
localClassNamesandlocalClassNameBindingsproperties onEmber.Componentsubclasses, as well as the@localClassNameand@localClassNamesdecorators that can be used as sugar for the same.These APIs rely on reopening the
Ember.Componentbase class, which is deprecated as of emberjs/rfcs#671, and they also belong to the pre-Octane programming model for Ember applications, since Glimmer components have no implicit root element for those APIs to even operate on. Accordingly, we'd like to drop them forember-css-modules@2.The changelog contains further details and several different recommendations for ways of migrating off of these APIs.