Fix classNames runtime helper for undefined and unmapped classes#335
Merged
dfreeman merged 4 commits intosalsify:standalone-template-transformfrom Feb 20, 2026
Conversation
5585991
into
salsify:standalone-template-transform
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undefined/null/empty string being passed toclassNames()in the runtime helper — previously threwTypeError: Cannot read properties of undefined (reading 'trim')??fallback inclassNames()was passing unknown classes (e.g. global utility classes like.is-hidden) to the DOM, which changed behavior from v2 where they were silently dropped. This caused issues like CSS transitions breaking when globaldisplay: noneclasses were unexpectedly applied.Test plan
vitest runpasses for runtime tests (3/3)See also: #318