fix: negative numbers return the wrong type #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taka-oyama
changed the title
Contributor
Author
|
Would it be possible to take a look at this and possibly get it merged (and released)? |
Contributor
|
@taka-oyama done. thanks for the reminder. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParseHelper::convertToNumberwas returning floats for negatives integers when it should have been returning int.jsonstreamingparser/src/ParserHelper.php
Line 50 in bc0d909
This is because
ctype_digitreturnsfalsefor negative numbers.So I have change the method to use
filter_var($text, FILTER_VALIDATE_INT)instead.