Use tpldir for template files too #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysql/config.sls
Outdated
| - source: salt://{{ tpldir }}/files/server.cnf | ||
| {% if os_family in ['Debian', 'Gentoo', 'RedHat'] %} | ||
| - context: | ||
| tpldir: {{ tpldir }} |
There was a problem hiding this comment.
for consistent indentation, remove two spaces
mysql/config.sls
Outdated
| - source: salt://{{ tpldir }}/files/galera.cnf | ||
| {% if os_family in ['Debian', 'Gentoo', 'RedHat'] %} | ||
| - context: | ||
| tpldir: {{ tpldir }} |
mysql/config.sls
Outdated
| - source: salt://{{ tpldir }}/files/client.cnf | ||
| {% if os_family in ['Debian', 'Gentoo', 'RedHat'] %} | ||
| - context: | ||
| tpldir: {{ tpldir }} |
noelmcloughlin
suggested changes
Jun 24, 2018
There was a problem hiding this comment.
This is good addition. can you fix minor indentation inconsistency so we can merge this!! thanks @mkotsbak
mysql/config.sls
Outdated
| - source: salt://{{ tpldir }}/files/my.cnf | ||
| {% endif %} | ||
| - context: | ||
| tpldir: {{ tpldir }} |
Using tpldir sent to templates through context.
mkotsbak
force-pushed
the
fix_relative_references_in_templates
branch
from
bc42a99 to
2b55567
Compare
|
Pushed updated commit. Good now? |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using tpldir sent to templates through context.