Skip to content

Conversation

@GeJ
Copy link
Contributor

@GeJ GeJ commented Aug 27, 2020

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

This is a followup on #250.

The patch I sent here suffered from a case of bad copy-n-paste and
missed half a level of indentation. Sorry.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

This is a followup on #250.

The patch I sent here suffered from a case of bad copy-n-paste and
missed half a level of indentation. Sorry.
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix(indent): properly indent file.directory block

Powered by Pull Assistant. Last update 7791268 ... 7791268. Read the comment docs.

@sticky-note sticky-note self-requested a review August 27, 2020 05:12
@sticky-note
Copy link
Member

LGTM

@sticky-note sticky-note merged commit d0a19a7 into saltstack-formulas:master Aug 27, 2020
@saltstack-formulas-travis

🎉 This PR is included in version 0.54.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants