fix(servers_config): fixup 05994e1 #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierbertoli
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
I checked this PR with the pillars @aboe76 provided as an example in #277 and it seems to work correctly now.
It'd be great if @aboe76 can give it a try and confirm.
myii
approved these changes
Mar 30, 2021
|
Appreciate the quick fix, @toanju. |
|
🎉 This PR is included in version 2.6.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Glad to hear. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per conversation in
5d7fc8d#commitcomment-48867113