Skip to content

Conversation

@pawelrosada
Copy link
Contributor

No description provided.

@sticky-note
Copy link
Member

sticky-note commented Mar 27, 2019

Thanks, is this variable is intended to use only with RedHat ?
Formulas fails in my side because I run it on a Debian server.
After investigation I found this 'enable_php_repo' var is only set for RedHat:

{% elif grains['os_family'] == "RedHat" and (state == 'cli' or state == 'fpm' or state == 'php') %}

but it used outside this if elsif statement ...

As documented on pillar, there is an 'use_external_repo' and 'external_repo_name' vars. What is different with this new var?

@ricariel
Copy link

Same as Issue #169

@aboe76
Copy link
Contributor

aboe76 commented Mar 27, 2019

@sticky-note can you test the proposed solution

@sticky-note
Copy link
Member

sticky-note commented Apr 1, 2019

It seems to work but #166 seems to introduce a mistake as it modify behavior for RedHat only ...

@ze42
Copy link

ze42 commented Apr 2, 2019

It works here too, properly fixes bug introduced by #166 for non-RedHat.

Fix kinda required for non-RedHat use.

@aboe76 aboe76 merged commit e0b922a into saltstack-formulas:master Apr 2, 2019
@aboe76
Copy link
Contributor

aboe76 commented Apr 2, 2019

merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants