Skip to content

feat(debian): add buster support #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2019
Merged

feat(debian): add buster support #278

merged 2 commits into from
Jul 24, 2019

Conversation

@johnkeates
Copy link
Contributor

@johnkeates johnkeates commented Jul 24, 2019 •
edited
Loading

feat(debian): add buster support

This adds support for Debian buster and native package installation. Fixes #276

aboe76
aboe76 reviewed Jul 24, 2019
View reviewed changes
@johnkeates
Copy link
Contributor Author

johnkeates commented Jul 24, 2019 •
edited
Loading

Travis doesn't seem to like my commit message for some reason. But the output doesn't really give me a pointer to what's wrong:

✖ subject may not be empty [subject-empty]
✖ type may not be empty [type-empty]

Subject isn't empty and type, there is no type?

@johnkeates johnkeates changed the title Update codenamemap.yaml for Debian Buster fix(postgres.server): codenamemap.yaml for Debian Buster Jul 24, 2019
noelmcloughlin
noelmcloughlin approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@noelmcloughlin noelmcloughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. thanks @johnkeates
If you change commit message to say feat(debian): add buster support it should work. Must be lower case however. See docs/CONTRIBUTING

@johnkeates johnkeates changed the title fix(postgres.server): codenamemap.yaml for Debian Buster feat(debian): add buster support Jul 24, 2019
@johnkeates
Copy link
Contributor Author

johnkeates commented Jul 24, 2019

Thanks @noelmcloughlin should be all better now

@noelmcloughlin
Copy link
Contributor

noelmcloughlin commented Jul 24, 2019

should be all better now

No, it's the commit message you need to change. ;-)

@johnkeates
Copy link
Contributor Author

johnkeates commented Jul 24, 2019

should be all better now

No, it's the commit message you need to change. ;-)

I really should RTFM :-D

@noelmcloughlin noelmcloughlin merged commit 0046482 into master Jul 24, 2019
@saltstack-formulas-travis
Copy link

saltstack-formulas-travis commented Jul 24, 2019

🎉 This PR is included in version 0.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@javierbertoli javierbertoli deleted the add-debian-buster-support branch February 7, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@aboe76 aboe76 aboe76 left review comments

@noelmcloughlin noelmcloughlin noelmcloughlin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Does not work with Debian Buster

5 participants

@johnkeates @noelmcloughlin @saltstack-formulas-travis @aboe76