Skip to content

fix(vim/init.sls): fix full vim installation on suse#49

Merged
myii merged 1 commit into
saltstack-formulas:masterfrom
stasjok:fix-suse-installation
Mar 1, 2021
Merged

fix(vim/init.sls): fix full vim installation on suse#49
myii merged 1 commit into
saltstack-formulas:masterfrom
stasjok:fix-suse-installation

Conversation

@stasjok

@stasjok stasjok commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

On Suse vim is split to 3 packages:

  • vim
  • vim-data-common (common data files for vim & gvim)
  • vim-data (data files)

vim-data-common is required, but vim-data is only recommended.
If solver.onlyRequires is enabled in Zypper (e.g. in JeOS),
only core vim is installed (without runtime *.vim files).
This commit allows to specify a list of packages for installation
and installs both vim and vim-data by default on Suse os_family.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

On Suse vim is split to 3 packages:
  - vim
  - vim-data-common (common data files for vim & gvim)
  - vim-data (data files)
vim-data-common is required, but vim-data is only recommended.
If solver.onlyRequires is enabled in Zypper (e.g. in JeOS),
only core vim is installed (without runtime *.vim files).
This commit allows to specify a list of packages for installation
and installs both vim and vim-data by default on Suse os_family.
@myii myii merged commit 3267844 into saltstack-formulas:master Mar 1, 2021
@myii

myii commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

Merged, thanks @stasjok!

@saltstack-formulas-travis

Copy link
Copy Markdown

🎉 This PR is included in version 0.15.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants