Solaris 10 - disk.percent - Problem parsing disk usage information

[PhillipRice]

bash-3.2# salt-call --versions-report
bash: salt-call: command not found
bash-3.2# /usr/local/opt/csw/bin/salt-call --versions-report
           Salt: 2014.1.3
         Python: 2.7.5 (default, Aug  9 2013, 18:44:52)
         Jinja2: 2.7.2
       M2Crypto: 0.21.1
 msgpack-python: 0.4.2
   msgpack-pure: Not Installed
       pycrypto: 2.6.1
         PyYAML: 3.11
          PyZMQ: 14.2.0
            ZMQ: 2.2.0

is msgpack-pure missing of concern?

we are having problem with disk.percent

bash-3.2# usr/local/opt/csw/bin/salt-call disk.percent
[INFO    ] Executing command '/usr/sbin/zfs help || :' in directory '/'
[INFO    ] Executing command 'df' in directory '/'
[INFO    ] output: /                  (/dev/dsk/c1t0d0s0 ): 3495082 blocks   486                                                           641 files
/devices           (/devices          ):       0 blocks        0 files
/system/contract   (ctfs              ):       0 blocks 2147483623 files
/proc              (proc              ):       0 blocks    12623 files
/etc/mnttab        (mnttab            ):       0 blocks        0 files
/etc/svc/volatile  (swap              ): 9084512 blocks   111499 files
/system/object     (objfs             ):       0 blocks 2147483474 files
/etc/dfs/sharetab  (sharefs           ):       0 blocks 2147483646 files
/usr               (/dev/dsk/c1t0d0s5 ): 3255730 blocks   466398 files
/lib/libc.so.1     (/usr/lib/libc/libc_hwcap1.so.1): 3255730 blocks   466398 fil                                                           es
/dev/fd            (fd                ):       0 blocks        0 files
/var               (/dev/dsk/c1t0d0s3 ): 3801488 blocks   482852 files
/tmp               (swap              ): 9084512 blocks   111499 files
/var/run           (swap              ): 9084512 blocks   111499 files
/usr/local         (/dev/dsk/c1t0d0s7 ):76653186 blocks  4833199 files
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
[WARNING ] Problem parsing disk usage information
local:

Thanks

[basepi]

No, it's not of concern. I'm guessing that the output of df is slightly different on Solaris 10 and so we just need to add some additional parsing logic. Thanks for the report!

[terminalmage]

@ricey99 I don't happen to have a Solaris box where I can test this, but I just added Solaris support for the functions in the disk execution module. Could you do the following:

1. Download this file and save it inside a directory called _modules in the root of your salt fileserver's base environment. If you don't know where that is, you can run salt mysol10minion pillar.get master:file_roots, like so:

   root@saltmine:~erik/saltdev# salt saltmine pillar.get master:file_roots
   saltmine:
   ----------
   base:
       - /home/erik/saltdev/srv/salt/base
   other:
       - /home/erik/saltdev/srv/salt/other
   

   For example, given the above. The file would need to be saved to /home/erik/saltdev/srv/salt/base/_modules/disk.py.

2. Sync the updated disk module to the minion by running salt mysol10minion saltutil.sync_modules.

3. Test each of the following execution functions, and post the results.

   • disk.usage
   • disk.percent
   • disk.inodeusage
   • disk.percent
   • disk.blkid

That last one should show an error message saying it is not supported, but before it would almost certainly have thrown a traceback.

Just remember to remove that file you saved and re-run that sync command before you upgrade Salt to a new version, as the sync'ed version takes precedence and keeping the copy I gave you there may result in unexpected behavior in the future.

[terminalmage]

I've also re-categorized this as High Severity since none of the functions in this module work properly in Solaris.

[skycree]

@terminalmage, I'm working with @ricey99 on this and I was able to import the module to a minion. Here's the module import:

Here's the output for disk.usage, disk.percent

salt 'salt-minion-sol-2' disk.inodeusage
salt-minion-sol-2:
----------
/:
----------
filesystem:
ufs
free:
No information found
use:
No information found
used:
No information found
/dev/fd:
----------
filesystem:
fd
free:
No information found
use:
No information found
used:
No information found
/devices:
----------
filesystem:
devfs
free:
No information found
use:
No information found
used:
No information found
/etc/dfs/sharetab:
----------
filesystem:
sharefs
free:
No information found
use:
No information found
used:
No information found
/etc/mnttab:
----------
filesystem:
mntfs
free:
No information found
use:
No information found
used:
No information found
/etc/svc/volatile:
----------
filesystem:
tmpfs
free:
No information found
use:
No information found
used:
No information found
/lib/libc.so.1:
----------
filesystem:
lofs
free:
No information found
use:
No information found
used:
No information found
/proc:
----------
filesystem:
proc
free:
No information found
use:
No information found
used:
No information found
/system/contract:
----------
filesystem:
ctfs
free:
No information found
use:
No information found
used:
No information found
/system/object:
----------
filesystem:
objfs
free:
No information found
use:
No information found
used:
No information found
/tmp:
----------
filesystem:
tmpfs
free:
No information found
use:
No information found
used:
No information found
/usr:
----------
filesystem:
ufs
free:
No information found
use:
No information found
used:
No information found
/usr/local:
----------
filesystem:
ufs
free:
No information found
use:
No information found
used:
No information found
/var:
----------
filesystem:
ufs
free:
No information found
use:
No information found
used:
No information found
/var/run:
----------
filesystem:
tmpfs
free:
No information found
use:
No information found
used:
No information found

Here is disk.blkid:

Let me know if text is better than posting images.

Thanks

[skycree]

Hi @terminalmage,

I think i found the fix with the disk.py script. It was the location of '/usr/xpg4/bin/df' does not exist on our Solaris systems. We are using Solaris 10 x86, SunOS salt-minion-sol-1 5.10 Generic_137138-09 i86pc i386 i86pc (we probably should have clarified this in the beginning). I modified the path in the script to '/usr/sbin/df -k' and received the following output for disk.usage:

---

[root@salt-master _modules]# salt 'salt-minion-sol-1' disk.usage
salt-minion-sol-1:
----------
/:
----------
available:
1687758
capacity:
13%
filesystem:
/dev/dsk/c1t0d0s0
used:
239095
/dev/fd:
----------
available:
0
capacity:
0%
filesystem:
fd
used:
0
/devices:
----------
available:
0
capacity:
0%
filesystem:
/devices
used:
0
/etc/dfs/sharetab:
----------
available:
0
capacity:
0%
filesystem:
sharefs
used:
0
/etc/mnttab:
----------
available:
0
capacity:
0%
filesystem:
mnttab
used:
0
/etc/svc/volatile:
----------
available:
4647416
capacity:
1%
filesystem:
swap
used:
596
/lib/libc.so.1:
----------
available:
1568272
capacity:
19%
filesystem:
/usr/lib/libc/libc_hwcap1.so.1
used:
358581
/proc:
----------
available:
0
capacity:
0%
filesystem:
proc
used:
0
/system/contract:
----------
available:
0
capacity:
0%
filesystem:
ctfs
used:
0
/system/object:
----------
available:
0
capacity:
0%
filesystem:
objfs
used:
0
/tmp:
----------
available:
4647416
capacity:
1%
filesystem:
swap
used:
8
/usr:
----------
available:
1568272
capacity:
19%
filesystem:
/dev/dsk/c1t0d0s5
used:
358581
/usr/local:
----------
available:
37922909
capacity:
6%
filesystem:
/dev/dsk/c1t0d0s7
used:
2057887
/var:
----------
available:
1840878
capacity:
5%
filesystem:
/dev/dsk/c1t0d0s3
used:
85975
/var/run:
----------
available:
4647416
capacity:
1%
filesystem:
swap
used:
24
512-blocks:
40384642

---

Furthermore we do not have /etc/mtab, so I changed reference to /etc/vfstab.

---

---

[root@salt-master _modules]# salt 'salt-minion-sol-1' disk.inodeusage
salt-minion-sol-1:
----------
/:
----------
filesystem:
ufs
free:
486635
use:
1%
used:
2581
/dev/fd:
----------
filesystem:
fd
free:
Not applicable
use:
Not applicable
used:
Not applicable
/devices:
----------
filesystem:
devfs
free:
Not applicable
use:
Not applicable
used:
Not applicable
/etc/dfs/sharetab:
----------
filesystem:
sharefs
free:
Not applicable
use:
Not applicable
used:
Not applicable
/etc/mnttab:
----------
filesystem:
mntfs
free:
Not applicable
use:
Not applicable
used:
Not applicable
/etc/svc/volatile:
----------
filesystem:
tmpfs
free:
Not applicable
use:
Not applicable
used:
Not applicable
/lib/libc.so.1:
----------
filesystem:
lofs
free:
Not applicable
use:
Not applicable
used:
Not applicable
/proc:
----------
filesystem:
proc
free:
Not applicable
use:
Not applicable
used:
Not applicable
/system/contract:
----------
filesystem:
ctfs
free:
Not applicable
use:
Not applicable
used:
Not applicable
/system/object:
----------
filesystem:
objfs
free:
Not applicable
use:
Not applicable
used:
Not applicable
/tmp:
----------
filesystem:
tmpfs
free:
Not applicable
use:
Not applicable
used:
Not applicable
/usr:
----------
filesystem:
ufs
free:
466398
use:
5%
used:
22818
/usr/local:
----------
filesystem:
ufs
free:
4833199
use:
1%
used:
29841
/var:
----------
filesystem:
ufs
free:
482834
use:
1%
used:
6382
/var/run:
----------
filesystem:
tmpfs
free:
Not applicable
use:
Not applicable
used:
Not applicable

---

[root@salt-master _modules]# salt 'salt-minion-sol-1' disk.blkid
salt-minion-sol-1:
ERROR: Not supported

[basepi]

Thanks for the updates. As a side note, I have actually changed this to a Feature instead of a high severity bug. I think solaris support for these modules fits there better.