Multiple keyword arguments in publish.publish doesn't work

[clinta]

Testing the example documented.

Only tested on 2014.7 right now. Will try and test develop.

root@minion:/# salt-call publish.publish minion test.kwarg arg="['cheese=spam','spam=cheese']"
local:
    ----------
    minion:
        TypeError encountered executing test.kwarg: kwarg() takes exactly 0 arguments (9 given). See debug log for more info.

The debug log has this:

[salt.minion      ][WARNING ] TypeError encountered executing test.kwarg: kwarg() takes exactly 0 arguments (9 given). See debug log for more info.
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/salt/minion.py", line 1022, in _thread_return
    return_data = func(*args, **kwargs)
TypeError: kwarg() takes exactly 0 arguments (9 given)

[jfindlay]

@clinta, thanks for reporting.

[kev009]

This still seems to be an issue in 2015.8.3

[kev009]

Empirically, the arg format expected is actually a list of positional args. For instance:
salt.publish.runners('myrunner', ['arg1', 'arg2']). I'm not sure kwargs are functional through the publisher module as implemented. _parse_args in modules/publish.py looks suspicious but with an hour of hacking around that and runners.py I wasn't able to make much sense of what is supposed to be happening.

[bruce-one]

The example given above appears to be working for me with the v2016.3.0 git tag:

root@929c10890396:/# salt-call publish.publish 2ee0fd489050 test.kwarg arg="['cheese=spam','spam=cheese']"
[INFO    ] Publishing 'test.kwarg' to tcp://172.17.0.4:4506
local:
    ----------
    2ee0fd489050:
        ----------
        __pub_arg:
            - cheese=spam
            - spam=cheese
        __pub_fun:
            test.kwarg
        __pub_id:
            929c10890396
        __pub_jid:
            20160603050339825695
        __pub_ret:
        __pub_tgt:
            2ee0fd489050
        __pub_tgt_type:
            glob
        __pub_user:
            root
        cheese:
            spam
        spam:
            cheese

I'm not sure if I'm reading the issue correctly, but just thought I'd mention it in case it's helpful :-)

ps, test.arg looks good too:

root@929c10890396:/# salt-call publish.publish 2ee0fd489050 test.arg arg="['a', 'cheese=spam','spam=cheese']"
[INFO    ] Publishing 'test.arg' to tcp://172.17.0.4:4506
local:
    ----------
    2ee0fd489050:
        ----------
        args:
            - a
        kwargs:
            ----------
            __pub_arg:
                - a
                - cheese=spam
                - spam=cheese
            __pub_fun:
                test.arg
            __pub_id:
                929c10890396
            __pub_jid:
                20160603050635269847
            __pub_ret:
            __pub_tgt:
                2ee0fd489050
            __pub_tgt_type:
                glob
            __pub_user:
                root
            cheese:
                spam
            spam:
                cheese

(

root@929c10890396:/# salt --version
salt 2016.3.0 (Boron)

)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.