pip.installed should accept arbitrary options to pass to pip

[corywright]

I am in a situation where I need to be able to supply pip with the --trusted-host option, but there appears to be no way to do this using salt's pip.installed state.

All options available to pass through to pip are hardwired into the pip.installed declaration, and there is no **kwargs at the end to allow arbitrary options to be passed through to pip. This creates a situation where upstream pip can add new options, but those options will not be available to salt until someone explicitly adds the new options to the pip execution and state modules.

[justinta]

@corywright Thanks for the feature request!

[anitakrueger]

+1
I am also running into the problem of needing to add trusted-host and can see that this is going to be a pain going forward as pip options are added.

[kaihowl]

Sorry to rain on the parade:
The merged commit e129815 does not solve the issue as the parameter and its value must be passed as to items in the options array. Right now this is passed as one option and therefore pip rightfully complains that the option "--trusted-host hostname" does not exist.

['/usr/local/bin/pip2', 'install', '--index-url', 'http://example.com/packages', 'somepackage==1.0.0', '--trusted-host example.com']

[corywright]

Originally my issue requested a way to pass arbitrary keywords through to pip, not only --trusted-host.

For example, pip 8 was recently released and added a new --prefix option. If salt supported a way to pass arbitrary keywords through to pip then this would already be supported. Instead, every time pip adds a new flag we'll have to wait for salt to be updated to support it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.