[BUG] `minion_data_cache: False` causes all targetting by pillar to fail

[ari]

In order to try and avoid some caching issues, I set in the master config:

minion_data_cache: False

Expected behavior
Salt would run a little slower without this cache, but everything would still function as expected.

Versions Report
Salt: 3002.6

What actually happen
All pillar targetting fails, which breaks many things in dramatic ways.

In my opinion, having a feature which breaks fundamental parts of the system, labelled in a way to suggest it is just a cache, is just wrong and has caused both outages and dozens of hours of wasted time for me. Either this is just a cache, in which case the broken functionality should be fixed, or it should be removed as an option.

[sagetherage]

@ari we will review a PR if you are willing to submit one

[ari]

A PR which does what? Removes the feature?

[sagetherage]

Is that the only way you can see a fix here?

[ari]

I can't see how the feature would ever be useful and wouldn't break significant things. Is the developer who added it still around to explain what it was designed to do?

[sagetherage]

I will have to find out

[ari]

bump