[BUG] "Recursive requisite found" in a state that worked before

[sylvainfaivre]

This problem appeared in the rabbitmq-formula's CI tests, with no code change in the formula, but changes to the Salt release used in the CI.

• Run OK :

CI run on Dec 12, using saltstack master branch, commit fc65161 (merged on Dec 4)
https://gitlab.com/saltstack-formulas/rabbitmq-formula/-/jobs/5734682005
From the log :
You asked for latest and you have 3007.0+0na.fc65161 installed, sweet!

CI results : all OK.

• BAD run :

CI run on Jan 11, using saltstack master branch, commit daef761 (merged on Jan 11)
https://gitlab.com/saltstack-formulas/rabbitmq-formula/-/jobs/5912410639
From the log :
You asked for latest and you have 3007.0+0na.daef761 installed, sweet!

Error in the CI run :

       ----------
                 ID: rabbitmq-config-plugins-rabbit-rabbitmqadmin-install
           Function: cmd.run
               Name: curl -k -L http://127.0.0.1:15672/cli/rabbitmqadmin -o /usr/local/sbin/rabbitmqadmin
             Result: False
            Comment: Recursive requisite found
            Changes:   
       ----------

I looked a bit into the git log, and I think this might be caused by https://github.com/saltstack/salt/pull/65326/files which was merged on Dec 8, so it fits in the time frame, altough I'm not enough of a coder to really investigate it.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on LiberaChat
• Salt Project YouTube channel
• Salt Project Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[eedgar]

The apache module is suffering from this issue also.

the reload, restart and apache service states all 3 claim a recursive issue is now happening. I revert from 3007.0 back to 3006.7 and the issue goes away

[sylvainfaivre]

#66135 might help, we'll see when it's merged

[dehnert]

#66135 might help, we'll see when it's merged

@sylvainfaivre , Do you happen to know if it did?

[sylvainfaivre]

#66135 might help, we'll see when it's merged

@sylvainfaivre , Do you happen to know if it did?

There was no release since this was merged, so I didn't try it.

[dehnert]

It looks like it's been merged to master now, so I assume it'll be in v3008. I think I ran into the issue with a recent 3007 and I don't see an obvious sign in the PR that it's been merged, so I'm guessing it's not in the maintenance releases.