[Bug]: salt-minion 3006.24: SyntaxWarning: "is not" with a literal. Did you mean "!="? in linode/api.py

[dimitry-unified-streaming]

What happened?

Upgrading from salt-minion 3006.23 to 3006.24 on Debian/Ubuntu systems results in python 3.10 warnings about "is" and "is not" which should probably have been "!=" and "==":

Unpacking salt-common (3006.24) over (3006.23) ...
Preparing to unpack .../salt-minion_3006.24_amd64.deb ...
Unpacking salt-minion (3006.24) over (3006.23) ...
Setting up salt-common (3006.24) ...
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:293: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if s['ERRORARRAY'][0]['ERRORCODE'] is not 0:
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:348: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(wrapper.__doc__.split('\n')) is 1:  # one-liners need whitespace
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:356: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(wrapper.__doc__.split('\n')) is 1:  # one-liners need whitespace
Setting up salt-minion (3006.24) ...

Note that the installations/upgrades do not fail, this is purely cosmetic. But it would be nice to get rid of the needless warnings.

Type of salt install

Official deb

Major version

3006.x

What supported OS are you seeing the problem on? Can select multiple. (If bug appears on an unsupported OS, please open a GitHub Discussion instead)

ubuntu-24.04

salt --versions-report output

Salt Version:
          Salt: 3006.24

Python Version:
        Python: 3.10.20 (main, Apr 22 2026, 05:54:37) [GCC 11.2.0]

Dependency Versions:
          cffi: 2.0.0
      cherrypy: unknown
  cryptography: 46.0.7
      dateutil: 2.8.2
     docker-py: Not Installed
         gitdb: 4.0.12
     gitpython: 3.1.46
        Jinja2: 3.1.6
       libgit2: Not Installed
  looseversion: 1.3.0
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 1.0.7
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 24.0
     pycparser: 2.21
      pycrypto: Not Installed
  pycryptodome: 3.23.0
        pygit2: Not Installed
  python-gnupg: 0.5.2
        PyYAML: 6.0.1
         PyZMQ: 25.1.2
        relenv: 0.22.8
         smmap: 5.0.2
       timelib: 0.3.0
       Tornado: 6.5.5
           ZMQ: 4.3.4

System Versions:
          dist: ubuntu 24.04.4 noble
        locale: utf-8
       machine: x86_64
       release: 6.17.0-22-generic
        system: Linux
       version: Ubuntu 24.04.4 noble

[m0duspwnens]

The same message was seen on Oracle Linux 9.

Salt Version:
          Salt: 3006.24
 
Python Version:
        Python: 3.10.20 (main, Apr 22 2026, 05:54:37) [GCC 11.2.0]
 
Dependency Versions:
          cffi: 2.0.0
      cherrypy: unknown
  cryptography: 46.0.7
      dateutil: 2.8.2
     docker-py: 7.1.0
         gitdb: 4.0.12
     gitpython: 3.1.46
        Jinja2: 3.1.6
       libgit2: Not Installed
  looseversion: 1.3.0
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 1.0.7
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 24.0
     pycparser: 2.21
      pycrypto: Not Installed
  pycryptodome: 3.23.0
        pygit2: Not Installed
  python-gnupg: 0.5.2
        PyYAML: 6.0.1
         PyZMQ: 25.1.2
        relenv: 0.22.8
         smmap: 5.0.2
       timelib: 0.3.0
       Tornado: 6.5.5
           ZMQ: 4.3.4
 
System Versions:
          dist: oracle 9.7 
        locale: utf-8
       machine: x86_64
       release: 5.15.0-319.201.4.2.el9uek.x86_64
        system: Linux
       version: Oracle Linux Server 9.7

[ssoto2]

Also seeing this during RPM install

  Running scriptlet: salt-3006.24-0.x86_64                                                                                                                                                                                               
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:293: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if s['ERRORARRAY'][0]['ERRORCODE'] is not 0:
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:348: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(wrapper.__doc__.split('\n')) is 1:  # one-liners need whitespace
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:356: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(wrapper.__doc__.split('\n')) is 1:  # one-liners need whitespace

Salt Version:
          Salt: 3006.24
 
Python Version:
        Python: 3.10.20 (main, Apr 22 2026, 05:54:37) [GCC 11.2.0]
 
Dependency Versions:
          cffi: 2.0.0
      cherrypy: unknown
  cryptography: 46.0.7
      dateutil: 2.8.2
     docker-py: Not Installed
         gitdb: 4.0.12
     gitpython: Not Installed
        Jinja2: 3.1.6
       libgit2: Not Installed
  looseversion: 1.3.0
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 1.0.7
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 24.0
     pycparser: 2.21
      pycrypto: Not Installed
  pycryptodome: 3.23.0
        pygit2: Not Installed
  python-gnupg: 0.5.2
        PyYAML: 6.0.1
         PyZMQ: 25.1.2
        relenv: 0.22.8
         smmap: 5.0.2
       timelib: 0.3.0
       Tornado: 6.5.5
           ZMQ: 4.3.4
 
System Versions:
          dist: rocky 8.10 Green Obsidian
        locale: utf-8
       machine: x86_64
       release: 4.18.0-553.40.1.el8_10.x86_64
        system: Linux
       version: Rocky Linux 8.10 Green Obsidian

[ewenmcneill]

Also seeing this on Debian 12 (Bookworm), new since saltstack 3006.24

Setting up salt-common (3006.24) ...
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:293: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if s['ERRORARRAY'][0]['ERRORCODE'] is not 0:
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:348: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(wrapper.__doc__.split('\n')) is 1:  # one-liners need whitespace
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:356: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(wrapper.__doc__.split('\n')) is 1:  # one-liners need whitespace

As far as I can tell the relevant file /opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py appears to be an exact match for an older commit of the now archived linode-python API:

https://github.com/tjfontaine/linode-python/blob/master/linode/api.py

In particular I can get a 100% match on that file with:

ewen@debian-bookworm:/tmp$ git clone https://github.com/tjfontaine/linode-python.git
Cloning into 'linode-python'...
remote: Enumerating objects: 710, done.
remote: Counting objects: 100% (3/3), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 710 (delta 0), reused 0 (delta 0), pack-reused 707 (from 1)
Receiving objects: 100% (710/710), 173.96 KiB | 2.02 MiB/s, done.
Resolving deltas: 100% (401/401), done.
ewen@debian-bookworm:/tmp$ cd linode-python/
ewen@debian-bookworm:/tmp/linode-python$ git show 6c1299fa18af9550d5a6501af664e73329b20aaf:linode/api.py  | diff - /opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py
ewen@debian-bookworm:/tmp/linode-python$ echo $?
0
ewen@debian-bookworm:/tmp/linode-python$ 

which is this code:

https://github.com/tjfontaine/linode-python/blob/6c1299fa18af9550d5a6501af664e73329b20aaf/linode/api.py

from February 2015.

From playing with "git annotate" the problematic constructs (is not 0, is 1) have been there since 2009.

So I assume the issue is that (a) this reliance on "small integers share a single object" implementation has never been fixed in this bundled library, and (b) the saltstack bundled Python is now verbosely objecting to this mistake, instead of silently accepting it.

Given that https://github.com/tjfontaine/linode-python has been archived since 2026-03-21, and looks basically unmaintained since 2016, I'd say there's zero chance of an upstream fix. So either saltstack locally fixes the library to be more modern Python, or drops the library dependency (there seem to be other Linnode Python APIs around, but presumably with a different call interface).

Ewen

[doc75]

On debian 13 very similar error seen when installing salt-common in version 3007.14:

Setting up salt-common (3007.14) ...
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:293: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if s['ERRORARRAY'][0]['ERRORCODE'] is not 0:
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:348: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(wrapper.__doc__.split('\n')) is 1:  # one-liners need whitespace
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:356: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(wrapper.__doc__.split('\n')) is 1:  # one-liners need whitespace

[fuzzypenguins]

Debian 13 salt-common version 3006.24

Unpacking salt-minion (3006.24) ...
Setting up salt-common (3006.24) ...
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:293: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if s['ERRORARRAY'][0]['ERRORCODE'] is not 0:
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:348: SyntaxWarning: "is" with a literal. Did you mean "=="?
if len(wrapper.doc.split('\n')) is 1: # one-liners need whitespace
/opt/saltstack/salt/lib/python3.10/site-packages/linode/api.py:356: SyntaxWarning: "is" with a literal. Did you mean "=="?
if len(wrapper.doc.split('\n')) is 1: # one-liners need whitespace
Setting up debconf-utils (1.5.91) ...